Lock / Unlock & bank logo

Author: simonredfern

src/lib/utils/errorHandler.ts

@@ -57,11 +57,6 @@ export async function extractErrorFromResponse(
     // Store full error for logging
     details.fullError = errorData;
 
-    // If we have an error code, prepend it to the message
-    if (details.code && !details.message.includes(details.code)) {
-      details.message = `${details.code}: ${details.message}`;
-    }
-
   } catch (parseError) {
     // If JSON parsing fails, try to get text response
     try {
@@ -114,14 +109,7 @@ export function extractErrorMessage(
  * @returns string - Formatted error message
  */
 export function formatErrorForDisplay(details: OBPErrorDetails): string {
-  let message = details.message;
-
-  // Add status code if not already in message
-  if (details.status && !message.includes(details.status.toString())) {
-    message = `${message} (Status: ${details.status})`;
-  }
-
-  return message;
+  return details.message;
 }
 
 /**

src/routes/(protected)/abac/rules/[rule_id]/edit/+page.svelte

@@ -319,8 +319,8 @@
       } else {
         validationStatus = "invalid";
         validationError =
-          result.error || result.message || "Rule validation failed";
-        validationDetails = result;
+          result.message || "Rule validation failed";
+        validationDetails = null;
       }
     } catch (err) {
       validationStatus = "invalid";

src/routes/(protected)/banks/+page.svelte

@@ -210,7 +210,7 @@
                     title="Set {bank.full_name || bank.bank_id} as current bank"
                     onclick={() => currentBank.select(bank)}
                   >
-                    {#if bank.logo}
+                    {#if bank.logo && !bank.logo.includes('example.com')}
                       <img
                         src={bank.logo}
                         alt="{bank.full_name} logo"

src/routes/(protected)/banks/[bankId]/+page.svelte

@@ -92,7 +92,7 @@
 
   <!-- Header -->
   <div class="mb-6 flex items-start gap-6">
-    {#if bank.logo}
+    {#if bank.logo && !bank.logo.includes('example.com')}
       <img
         src={bank.logo}
         alt="{bank.full_name} logo"

src/routes/(protected)/rbac/banks/+page.svelte

@@ -131,7 +131,7 @@
           {#each filteredBanks as bank}
             <div class="bank-card">
               <div class="bank-header">
-                {#if bank.logo}
+                {#if bank.logo && !bank.logo.includes('example.com')}
                   <img src={bank.logo} alt={bank.short_name} class="bank-logo" />
                 {:else}
                   <div class="bank-logo-placeholder">

src/routes/(protected)/users/[provider]/[username]/+page.svelte

@@ -86,10 +86,10 @@
             <div class="info-value">
               {#if user.is_locked}
                 <span class="badge badge-error">Yes</span>
-                <a href="/users/{encodeURIComponent(data.provider)}/{encodeURIComponent(data.username)}/unlock" class="action-link">Unlock User</a>
+                <a href="/users/{encodeURIComponent(data.provider)}/{encodeURIComponent(data.username)}/unlock" class="action-link" style="color: #059669;">Unlock User</a>
               {:else}
                 <span class="badge badge-success">No</span>
-                <a href="/users/{encodeURIComponent(data.provider)}/{encodeURIComponent(data.username)}/lock" class="action-link">Lock User</a>
+                <a href="/users/{encodeURIComponent(data.provider)}/{encodeURIComponent(data.username)}/lock" class="action-link" style="color: #dc2626;">Lock User</a>
               {/if}
             </div>
           </div>
@@ -481,9 +481,6 @@
     text-decoration: underline;
   }
 
-  :global([data-mode="dark"]) .action-link {
-    color: rgb(var(--color-primary-400));
-  }
 
   .empty-state {
     text-align: center;

src/routes/(protected)/users/[user_id]/+page.svelte

@@ -90,12 +90,12 @@
               {#if user.is_locked}
                 <span class="badge badge-error">Yes</span>
                 {#if user.provider && user.username}
-                  <a href="/users/{encodeURIComponent(user.provider)}/{encodeURIComponent(user.username)}/unlock" class="action-link">Unlock User</a>
+                  <a href="/users/{encodeURIComponent(user.provider)}/{encodeURIComponent(user.username)}/unlock" class="action-link" style="color: #059669;">Unlock User</a>
                 {/if}
               {:else}
                 <span class="badge badge-success">No</span>
                 {#if user.provider && user.username}
-                  <a href="/users/{encodeURIComponent(user.provider)}/{encodeURIComponent(user.username)}/lock" class="action-link">Lock User</a>
+                  <a href="/users/{encodeURIComponent(user.provider)}/{encodeURIComponent(user.username)}/lock" class="action-link" style="color: #dc2626;">Lock User</a>
                 {/if}
               {/if}
             </div>
@@ -508,9 +508,6 @@
     text-decoration: underline;
   }
 
-  :global([data-mode="dark"]) .action-link {
-    color: rgb(var(--color-primary-400));
-  }
 
   .system-wide-badge {
     display: inline-block;

src/routes/api/abac-rules/validate/+server.ts

@@ -60,22 +60,17 @@ export const POST: RequestHandler = async ({ request, locals }) => {
     logger.debug("OBP API response:", JSON.stringify(response, null, 2));
 
     // OBP API response format should include validation result
+    // Only return the OBP error message verbatim
     return json({
       valid: response.valid ?? true,
-      error: response.error || null,
       message: response.message || null,
-      details: response.details || null,
     });
   } catch (err) {
     logger.error("Error validating ABAC rule:", err);
 
-    // Return full OBP error without sanitization
     return json({
       valid: false,
-      error: err instanceof Error ? err.message : String(err),
-      message: "Rule validation failed",
-      obpError: err,
-      fullError: JSON.stringify(err, Object.getOwnPropertyNames(err)),
+      message: err instanceof Error ? err.message : String(err),
     });
   }
 };