From 8f242de59aa8baa900d05ac4913832e38e306361 Mon Sep 17 00:00:00 2001 From: timosachsenberg Date: Thu, 5 Mar 2026 15:24:21 +0100 Subject: [PATCH 1/2] build: add libcurl-dev to Dockerfiles OpenMS core library now uses libcurl instead of Qt Network for HTTP operations. Add the development packages so the build can find curl headers and libraries. Co-Authored-By: Claude Opus 4.6 --- dockerfiles/Dockerfile | 1 + 1 file changed, 1 insertion(+) diff --git a/dockerfiles/Dockerfile b/dockerfiles/Dockerfile index 030abbe..988d0b0 100644 --- a/dockerfiles/Dockerfile +++ b/dockerfiles/Dockerfile @@ -19,6 +19,7 @@ RUN apt-get -y update \ zlib1g-dev \ libxerces-c-dev \ libbz2-dev \ + libcurl4-openssl-dev \ libomp-dev \ libhdf5-dev\ libboost-date-time1.74-dev \ From 2856db19f6d629ad86dd3223d995eca4d2b7eb0a Mon Sep 17 00:00:00 2001 From: Timo Sachsenberg Date: Mon, 9 Mar 2026 21:16:17 +0100 Subject: [PATCH 2/2] build: add -fPIC to static libcurl build Add CMAKE_POSITION_INDEPENDENT_CODE=ON to the curl cmake configuration. Without this, the static libcurl.a contains position-dependent relocations (R_X86_64_32S) that cannot be linked into libOpenMS.so, causing linker failures on Linux wheel builds. Co-Authored-By: Claude Opus 4.6 --- libraries.cmake/curl.cmake | 1 + 1 file changed, 1 insertion(+) diff --git a/libraries.cmake/curl.cmake b/libraries.cmake/curl.cmake index c571e81..c8f8410 100644 --- a/libraries.cmake/curl.cmake +++ b/libraries.cmake/curl.cmake @@ -43,6 +43,7 @@ execute_process(COMMAND ${CMAKE_COMMAND} -D CMAKE_BUILD_TYPE=Release -D CMAKE_INSTALL_PREFIX=${PROJECT_BINARY_DIR} -D BUILD_SHARED_LIBS=${BUILD_SHARED_LIBRARIES} + -D CMAKE_POSITION_INDEPENDENT_CODE=ON -D BUILD_CURL_EXE=OFF -D BUILD_TESTING=OFF -D CURL_DISABLE_LDAP=ON