From b2d2b0542075b3830900d19e82e6310cc50a81dd Mon Sep 17 00:00:00 2001
From: emjay0921 <michael@acn.fr>
Date: Thu, 12 Feb 2026 16:35:00 +0800
Subject: [PATCH] fix(spp_change_request_v2): add no_create/no_open to lookup
 fields in CR detail views

Prevent users from creating or editing configuration/lookup records
(gender, relationship, country, state, group type, role, ID type) and
registrant records directly from change request forms. Users should
only select from existing values.
---
 .../views/detail_add_member_views.xml                | 10 ++++++++--
 .../views/detail_change_hoh_views.xml                |  2 +-
 .../views/detail_create_group_views.xml              |  8 ++++----
 .../views/detail_edit_individual_views.xml           |  5 ++++-
 .../views/detail_exit_registrant_views.xml           |  1 +
 .../views/detail_merge_registrants_views.xml         |  6 +++++-
 .../views/detail_split_household_views.xml           | 12 ++++++++----
 .../views/detail_transfer_member_views.xml           |  7 +++++--
 .../views/detail_update_id_views.xml                 |  2 +-
 9 files changed, 37 insertions(+), 16 deletions(-)

diff --git a/spp_change_request_v2/views/detail_add_member_views.xml b/spp_change_request_v2/views/detail_add_member_views.xml
index d64c989..ae4ecff 100644
--- a/spp_change_request_v2/views/detail_add_member_views.xml
+++ b/spp_change_request_v2/views/detail_add_member_views.xml
@@ -47,8 +47,14 @@
                         </group>
                         <group>
                             <field name="birthdate" />
-                            <field name="gender_id" />
-                            <field name="relationship_id" />
+                            <field
+                                name="gender_id"
+                                options="{'no_create': True, 'no_open': True}"
+                            />
+                            <field
+                                name="relationship_id"
+                                options="{'no_create': True, 'no_open': True}"
+                            />
                         </group>
                     </group>
 
diff --git a/spp_change_request_v2/views/detail_change_hoh_views.xml b/spp_change_request_v2/views/detail_change_hoh_views.xml
index 251879c..bac6d69 100644
--- a/spp_change_request_v2/views/detail_change_hoh_views.xml
+++ b/spp_change_request_v2/views/detail_change_hoh_views.xml
@@ -55,7 +55,7 @@
                         <group string="Previous Head Reassignment">
                             <field
                                 name="previous_head_new_role_id"
-                                options="{'no_create': True}"
+                                options="{'no_create': True, 'no_open': True}"
                             />
                         </group>
                     </group>
diff --git a/spp_change_request_v2/views/detail_create_group_views.xml b/spp_change_request_v2/views/detail_create_group_views.xml
index 01e92be..b70259e 100644
--- a/spp_change_request_v2/views/detail_create_group_views.xml
+++ b/spp_change_request_v2/views/detail_create_group_views.xml
@@ -31,7 +31,7 @@
                     <group>
                         <group string="Group Information">
                             <field name="group_name" required="1" />
-                            <field name="group_type_id" options="{'no_create': True}" />
+                            <field name="group_type_id" options="{'no_create': True, 'no_open': True}" />
                         </group>
                         <group string="Contact">
                             <field name="phone" />
@@ -61,7 +61,7 @@
                             <field name="head_birthdate" />
                             <field
                                 name="head_gender_id"
-                                options="{'no_create': True}"
+                                options="{'no_create': True, 'no_open': True}"
                             />
                             <field name="head_phone" />
                         </group>
@@ -75,9 +75,9 @@
                             <field name="city" />
                         </group>
                         <group>
-                            <field name="state_id" options="{'no_create': True}" />
+                            <field name="state_id" options="{'no_create': True, 'no_open': True}" />
                             <field name="postal_code" />
-                            <field name="country_id" options="{'no_create': True}" />
+                            <field name="country_id" options="{'no_create': True, 'no_open': True}" />
                         </group>
                     </group>
 
diff --git a/spp_change_request_v2/views/detail_edit_individual_views.xml b/spp_change_request_v2/views/detail_edit_individual_views.xml
index 8d0eb34..02b93c1 100644
--- a/spp_change_request_v2/views/detail_edit_individual_views.xml
+++ b/spp_change_request_v2/views/detail_edit_individual_views.xml
@@ -44,7 +44,10 @@
                                     <field name="given_name" required="1" />
                                     <field name="family_name" required="1" />
                                     <field name="birthdate" />
-                                    <field name="gender_id" />
+                                    <field
+                                        name="gender_id"
+                                        options="{'no_create': True, 'no_open': True}"
+                                    />
                                 </group>
                                 <group>
                                     <field name="phone" />
diff --git a/spp_change_request_v2/views/detail_exit_registrant_views.xml b/spp_change_request_v2/views/detail_exit_registrant_views.xml
index f31d919..7a8813d 100644
--- a/spp_change_request_v2/views/detail_exit_registrant_views.xml
+++ b/spp_change_request_v2/views/detail_exit_registrant_views.xml
@@ -55,6 +55,7 @@
                             <field
                                 name="destination_country_id"
                                 invisible="exit_reason != 'emigrated'"
+                                options="{'no_create': True, 'no_open': True}"
                             />
                         </group>
                         <group string="Options">
diff --git a/spp_change_request_v2/views/detail_merge_registrants_views.xml b/spp_change_request_v2/views/detail_merge_registrants_views.xml
index ea80f7e..5910f15 100644
--- a/spp_change_request_v2/views/detail_merge_registrants_views.xml
+++ b/spp_change_request_v2/views/detail_merge_registrants_views.xml
@@ -40,7 +40,11 @@
 
                     <group>
                         <group string="Primary Registrant (Keep)">
-                            <field name="primary_registrant_id" required="1" />
+                            <field
+                                name="primary_registrant_id"
+                                required="1"
+                                options="{'no_create': True, 'no_open': True}"
+                            />
                             <field name="primary_name" invisible="1" />
                             <field name="is_group_merge" invisible="1" />
                             <field name="available_duplicate_ids" invisible="1" />
diff --git a/spp_change_request_v2/views/detail_split_household_views.xml b/spp_change_request_v2/views/detail_split_household_views.xml
index 76e8b73..45f4625 100644
--- a/spp_change_request_v2/views/detail_split_household_views.xml
+++ b/spp_change_request_v2/views/detail_split_household_views.xml
@@ -47,7 +47,11 @@
 
                     <group>
                         <group string="Source Household">
-                            <field name="source_group_id" required="1" />
+                            <field
+                                name="source_group_id"
+                                required="1"
+                                options="{'no_create': True, 'no_open': True}"
+                            />
                             <field name="source_group_name" invisible="1" />
                             <field name="available_member_ids" invisible="1" />
                             <field name="members_to_split_ids" invisible="1" />
@@ -89,7 +93,7 @@
                             <field name="new_group_name" required="1" />
                             <field
                                 name="new_group_type_id"
-                                options="{'no_create': True}"
+                                options="{'no_create': True, 'no_open': True}"
                             />
                         </group>
                         <group>
@@ -104,9 +108,9 @@
                             <field name="city" />
                         </group>
                         <group string="Location">
-                            <field name="state_id" options="{'no_create': True}" />
+                            <field name="state_id" options="{'no_create': True, 'no_open': True}" />
                             <field name="postal_code" />
-                            <field name="country_id" options="{'no_create': True}" />
+                            <field name="country_id" options="{'no_create': True, 'no_open': True}" />
                         </group>
                         <group string="Contact">
                             <field name="phone" />
diff --git a/spp_change_request_v2/views/detail_transfer_member_views.xml b/spp_change_request_v2/views/detail_transfer_member_views.xml
index 82d7435..4369ca7 100644
--- a/spp_change_request_v2/views/detail_transfer_member_views.xml
+++ b/spp_change_request_v2/views/detail_transfer_member_views.xml
@@ -30,7 +30,10 @@
                 <sheet>
                     <group>
                         <group string="Source">
-                            <field name="source_group_id" />
+                            <field
+                                name="source_group_id"
+                                options="{'no_create': True, 'no_open': True}"
+                            />
                             <field name="available_individual_ids" invisible="1" />
                             <field
                                 name="individual_id"
@@ -47,7 +50,7 @@
                                 options="{'no_create': True}"
                                 required="1"
                             />
-                            <field name="new_role_id" options="{'no_create': True}" />
+                            <field name="new_role_id" options="{'no_create': True, 'no_open': True}" />
                         </group>
                     </group>
                     <group>
diff --git a/spp_change_request_v2/views/detail_update_id_views.xml b/spp_change_request_v2/views/detail_update_id_views.xml
index 2342b6a..b59945b 100644
--- a/spp_change_request_v2/views/detail_update_id_views.xml
+++ b/spp_change_request_v2/views/detail_update_id_views.xml
@@ -51,7 +51,7 @@
                     </group>
                     <group invisible="operation == 'remove'">
                         <group string="ID Information">
-                            <field name="id_type_id" options="{'no_create': True}" />
+                            <field name="id_type_id" options="{'no_create': True, 'no_open': True}" />
                             <field name="id_value" required="operation == 'add'" />
                             <field name="expiry_date" />
                         </group>