fix: remove unnecessary tx

Author: smarcet

app/Services/OpenId/ServerExtensionsService.php

@@ -11,12 +11,14 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  **/
+
 use App\Repositories\IServerExtensionRepository;
 use App\Services\AbstractService;
 use OpenId\Services\IServerExtensionsService;
+use ReflectionClass;
 use Utils\Db\ITransactionService;
 use Utils\Services\ServiceLocator;
-use ReflectionClass;
+
 /**
  * Class ServerExtensionsService
  * @package Services\OpenId
@@ -30,44 +32,43 @@ final class ServerExtensionsService extends AbstractService implements IServerEx
 
     public function __construct(
         IServerExtensionRepository $server_extensions_repository,
-        ITransactionService $tx_service)
+        ITransactionService        $tx_service)
     {
         parent::__construct($tx_service);
         $this->server_extensions_repository = $server_extensions_repository;
     }
 
     /**
-	 * @return array
-	 */
-	public function getAllActiveExtensions()
+     * @return array
+     */
+    public function getAllActiveExtensions()
     {
-        return $this->tx_service->transaction(function(){
-            $extensions = $this->server_extensions_repository->getAllActives();
-            $res        = [];
-            foreach ($extensions as $extension) {
-                $class_name = $extension->getExtensionClass();
-                if (empty($class_name)) continue;
+        $extensions = $this->server_extensions_repository->getAllActives();
+        $res = [];
+        foreach ($extensions as $extension) {
+            $class_name = $extension->getExtensionClass();
+            if (empty($class_name)) continue;
 
-                $class              = new ReflectionClass($class_name);
-                $constructor        = $class->getConstructor();
-                $constructor_params = $constructor->getParameters();
+            $class = new ReflectionClass($class_name);
+            $constructor = $class->getConstructor();
+            $constructor_params = $constructor->getParameters();
 
-                $deps = [];
+            $deps = [];
 
-                foreach($constructor_params as $constructor_param){
-                    $param_class  = $constructor_param->getClass();
-                    if(is_null($param_class)){
-                        $property = $constructor_param->getName();
-                        $deps[] = $extension->{$property};
-                        continue;
-                    }
-                    $deps [] = ServiceLocator::getInstance()->getService($param_class->getName());
+            foreach ($constructor_params as $constructor_param) {
+                $param_class = $constructor_param->getClass();
+                if (is_null($param_class)) {
+                    $property = $constructor_param->getName();
+                    $deps[] = $extension->{$property};
+                    continue;
                 }
-
-                $res[] = $class->newInstanceArgs($deps);
+                $deps [] = ServiceLocator::getInstance()->getService($param_class->getName());
             }
-            return $res;
-        });
+
+            $res[] = $class->newInstanceArgs($deps);
+        }
+        return $res;
+
 
     }
 }