Skip to content

Commit 2db6e9b

Browse files
matiasperrone-exomatiasperrone-exo
authored
Chore | Remove renamed trait methods (#512)
* chore: Remove renamed trait methods * chore: Remove trait alias
1 parent 815b3ea commit 2db6e9b

3 files changed

Lines changed: 12 additions & 76 deletions

File tree

‎app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitBadgeTypeApiController.php‎

Lines changed: 5 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -97,25 +97,15 @@ protected function getOrderRules():array{
9797
];
9898
}
9999

100-
use GetAllBySummit {
101-
getAllBySummit as protected traitGetAllBySummit;
102-
}
100+
use GetAllBySummit;
103101

104-
use GetSummitChildElementById {
105-
get as protected traitGet;
106-
}
102+
use GetSummitChildElementById;
107103

108-
use AddSummitChildElement {
109-
add as protected traitAdd;
110-
}
104+
use AddSummitChildElement;
111105

112-
use UpdateSummitChildElement {
113-
update as protected traitUpdate;
114-
}
106+
use UpdateSummitChildElement;
115107

116-
use DeleteSummitChildElement {
117-
delete as protected traitDelete;
118-
}
108+
use DeleteSummitChildElement;
119109

120110
#[OA\Get(
121111
path: "/api/v1/summits/{id}/badge-types",
@@ -202,9 +192,6 @@ protected function getOrderRules():array{
202192
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
203193
]
204194
)]
205-
public function getAllBySummit($summit_id) {
206-
return $this->traitGetAllBySummit($summit_id);
207-
}
208195

209196
#[OA\Get(
210197
path: "/api/v1/summits/{id}/badge-types/{badge_type_id}",
@@ -268,9 +255,6 @@ public function getAllBySummit($summit_id) {
268255
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
269256
]
270257
)]
271-
public function get($summit_id, $badge_type_id) {
272-
return $this->traitGet($summit_id, $badge_type_id);
273-
}
274258

275259
#[OA\Post(
276260
path: "/api/v1/summits/{id}/badge-types",
@@ -316,9 +300,6 @@ public function get($summit_id, $badge_type_id) {
316300
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
317301
]
318302
)]
319-
public function add($summit_id) {
320-
return $this->traitAdd($summit_id);
321-
}
322303

323304
#[OA\Put(
324305
path: "/api/v1/summits/{id}/badge-types/{badge_type_id}",
@@ -371,9 +352,6 @@ public function add($summit_id) {
371352
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
372353
]
373354
)]
374-
public function update($summit_id, $badge_type_id) {
375-
return $this->traitUpdate($summit_id, $badge_type_id);
376-
}
377355

378356
#[OA\Delete(
379357
path: "/api/v1/summits/{id}/badge-types/{badge_type_id}",
@@ -416,9 +394,6 @@ public function update($summit_id, $badge_type_id) {
416394
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
417395
]
418396
)]
419-
public function delete($summit_id, $badge_type_id) {
420-
return $this->traitDelete($summit_id, $badge_type_id);
421-
}
422397

423398
/**
424399
* @param array $payload

‎app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitDocumentsApiController.php‎

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -42,17 +42,11 @@ class OAuth2SummitDocumentsApiController extends OAuth2ProtectedController
4242
{
4343
// traits
4444

45-
use GetAllBySummit {
46-
getAllBySummit as protected traitGetAllBySummit;
47-
}
45+
use GetAllBySummit;
4846

49-
use GetSummitChildElementById {
50-
get as protected traitGet;
51-
}
47+
use GetSummitChildElementById;
5248

53-
use DeleteSummitChildElement {
54-
delete as protected traitDelete;
55-
}
49+
use DeleteSummitChildElement;
5650

5751
use RequestProcessor;
5852

@@ -163,9 +157,6 @@ public function __construct
163157
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
164158
]
165159
)]
166-
public function getAllBySummit($summit_id) {
167-
return $this->traitGetAllBySummit($summit_id);
168-
}
169160

170161
#[OA\Get(
171162
path: "/api/v1/summits/{id}/summit-documents/{document_id}",
@@ -220,9 +211,6 @@ public function getAllBySummit($summit_id) {
220211
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
221212
]
222213
)]
223-
public function get($summit_id, $document_id) {
224-
return $this->traitGet($summit_id, $document_id);
225-
}
226214

227215
#[OA\Post(
228216
path: "/api/v1/summits/{id}/summit-documents",
@@ -486,9 +474,6 @@ public function update(LaravelRequest $request, $summit_id, $document_id){
486474
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
487475
]
488476
)]
489-
public function delete($summit_id, $document_id) {
490-
return $this->traitDelete($summit_id, $document_id);
491-
}
492477

493478
/**
494479
* @inheritDoc

‎app/Http/Controllers/Apis/Protected/Summit/OAuth2SummitSubmissionInvitationApiController.php‎

Lines changed: 4 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -48,21 +48,13 @@ final class OAuth2SummitSubmissionInvitationApiController extends OAuth2Protecte
4848

4949
use ParametrizedGetAll;
5050

51-
use GetSummitChildElementById {
52-
get as protected traitGet;
53-
}
51+
use GetSummitChildElementById;
5452

55-
use DeleteSummitChildElement {
56-
delete as protected traitDelete;
57-
}
53+
use DeleteSummitChildElement;
5854

59-
use AddSummitChildElement {
60-
add as protected traitAdd;
61-
}
55+
use AddSummitChildElement;
6256

63-
use UpdateSummitChildElement {
64-
update as protected traitUpdate;
65-
}
57+
use UpdateSummitChildElement;
6658

6759
/**
6860
* @var ISummitRepository
@@ -578,10 +570,6 @@ protected function updateChild(Summit $summit, int $child_id, array $payload): I
578570
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
579571
]
580572
)]
581-
public function get($summit_id, $invitation_id)
582-
{
583-
return $this->traitGet($summit_id, $invitation_id);
584-
}
585573

586574
#[OA\Post(
587575
path: "/api/v1/summits/{id}/submission-invitations",
@@ -632,10 +620,6 @@ public function get($summit_id, $invitation_id)
632620
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
633621
]
634622
)]
635-
public function add($summit_id)
636-
{
637-
return $this->traitAdd($summit_id);
638-
}
639623

640624
#[OA\Put(
641625
path: "/api/v1/summits/{id}/submission-invitations/{invitation_id}",
@@ -693,10 +677,6 @@ public function add($summit_id)
693677
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
694678
]
695679
)]
696-
public function update($summit_id, $invitation_id)
697-
{
698-
return $this->traitUpdate($summit_id, $invitation_id);
699-
}
700680

701681
#[OA\Delete(
702682
path: "/api/v1/summits/{id}/submission-invitations/{invitation_id}",
@@ -744,10 +724,6 @@ public function update($summit_id, $invitation_id)
744724
new OA\Response(response: Response::HTTP_INTERNAL_SERVER_ERROR, description: "Server Error")
745725
]
746726
)]
747-
public function delete($summit_id, $invitation_id)
748-
{
749-
return $this->traitDelete($summit_id, $invitation_id);
750-
}
751727

752728
#[OA\Delete(
753729
path: "/api/v1/summits/{id}/submission-invitations/all",

0 commit comments

Comments
 (0)