Fix PSScriptAnalyzer linting issues

Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>

Author: Copilot

src/functions/private/Auth/Context/Remove-PowerShellGalleryContext.ps1

@@ -33,7 +33,9 @@ function Remove-PowerShellGalleryContext {
             if ($script:PowerShellGallery.Config.DefaultContext -eq $ID) {
                 Write-Verbose 'Clearing default context'
                 $script:PowerShellGallery.Config.DefaultContext = $null
-                $null = Set-Context -ID $script:PowerShellGallery.DefaultConfig.ID -Context $script:PowerShellGallery.Config -Vault $script:PowerShellGallery.ContextVault
+                $configID = $script:PowerShellGallery.DefaultConfig.ID
+                $vault = $script:PowerShellGallery.ContextVault
+                $null = Set-Context -ID $configID -Context $script:PowerShellGallery.Config -Vault $vault
             }
         }
     }

src/functions/private/Auth/Context/Set-PowerShellGalleryContext.ps1

@@ -50,12 +50,14 @@ function Set-PowerShellGalleryContext {
         $contextObj['ID'] = $ID
 
         if ($PSCmdlet.ShouldProcess("Context [$ID]", 'Set')) {
-            $result = Set-Context -ID $ID -Context $contextObj -Vault $script:PowerShellGallery.ContextVault -PassThru
+            $vault = $script:PowerShellGallery.ContextVault
+            $result = Set-Context -ID $ID -Context $contextObj -Vault $vault -PassThru
 
             if ($Default) {
                 Write-Debug "Setting [$ID] as default context"
                 $script:PowerShellGallery.Config.DefaultContext = $ID
-                $null = Set-Context -ID $script:PowerShellGallery.DefaultConfig.ID -Context $script:PowerShellGallery.Config -Vault $script:PowerShellGallery.ContextVault
+                $configID = $script:PowerShellGallery.DefaultConfig.ID
+                $null = Set-Context -ID $configID -Context $script:PowerShellGallery.Config -Vault $vault
             }
 
             if ($PassThru) {

src/functions/public/Auth/Connect-PowerShellGallery.ps1

@@ -27,6 +27,10 @@ function Connect-PowerShellGallery {
         'PSAvoidUsingConvertToSecureStringWithPlainText', '',
         Justification = 'The API key is received as clear text from user input.'
     )]
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute(
+        'PSAvoidUsingWriteHost', '',
+        Justification = 'Is the CLI part of the module. Consistent with GitHub module pattern.'
+    )]
     [CmdletBinding(DefaultParameterSetName = 'Interactive')]
     [OutputType([System.Object])]
     param(
@@ -59,9 +63,9 @@ function Connect-PowerShellGallery {
             if (-not $Silent) {
                 Write-Host '🌐 Opening PowerShell Gallery API key management page...' -ForegroundColor Cyan
             }
-            
+
             $apiKeyUrl = 'https://www.powershellgallery.com/account/apikeys'
-            
+
             # Try to open browser
             try {
                 if ($IsWindows -or $PSVersionTable.PSVersion.Major -le 5) {

src/functions/public/Auth/Context/Switch-PowerShellGalleryContext.ps1

@@ -11,6 +11,10 @@ function Switch-PowerShellGalleryContext {
 
         Switches the default PowerShell Gallery context to 'MyAccount'.
     #>
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute(
+        'PSAvoidUsingWriteHost', '',
+        Justification = 'Is the CLI part of the module. Consistent with GitHub module pattern.'
+    )]
     [OutputType([void])]
     [CmdletBinding(SupportsShouldProcess)]
     param(
@@ -28,14 +32,17 @@ function Switch-PowerShellGalleryContext {
         # Verify the context exists
         $context = Get-Context -ID $ID -Vault $script:PowerShellGallery.ContextVault
         if (-not $context) {
-            Write-Error "Context [$ID] not found. Use 'Get-PowerShellGalleryContext -ListAvailable' to see available contexts."
+            $msg = "Context [$ID] not found. Use 'Get-PowerShellGalleryContext -ListAvailable' to see available contexts."
+            Write-Error $msg
             return
         }
 
         if ($PSCmdlet.ShouldProcess("Default context to [$ID]", 'Switch')) {
             Write-Verbose "Switching default context to [$ID]"
             $script:PowerShellGallery.Config.DefaultContext = $ID
-            $null = Set-Context -ID $script:PowerShellGallery.DefaultConfig.ID -Context $script:PowerShellGallery.Config -Vault $script:PowerShellGallery.ContextVault
+            $configID = $script:PowerShellGallery.DefaultConfig.ID
+            $vault = $script:PowerShellGallery.ContextVault
+            $null = Set-Context -ID $configID -Context $script:PowerShellGallery.Config -Vault $vault
             Write-Host "✓ Switched to context [$ID]" -ForegroundColor Green
         }
     }

src/functions/public/Auth/Disconnect-PowerShellGallery.ps1

@@ -17,6 +17,10 @@ function Disconnect-PowerShellGallery {
         Removes the default context.
     #>
     [CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute(
+        'PSAvoidUsingWriteHost', '',
+        Justification = 'Is the CLI part of the module. Consistent with GitHub module pattern.'
+    )]
     [OutputType([void])]
     param(
         # The name of the context to remove. If not specified, removes the default context.

src/functions/public/Auth/Test-PowerShellGalleryAccess.ps1

@@ -17,6 +17,10 @@ function Test-PowerShellGalleryAccess {
 
         Tests access using the 'MyAccount' context.
     #>
+    [Diagnostics.CodeAnalysis.SuppressMessageAttribute(
+        'PSAvoidUsingWriteHost', '',
+        Justification = 'Is the CLI part of the module. Consistent with GitHub module pattern.'
+    )]
     [CmdletBinding()]
     [OutputType([System.Object])]
     param(
@@ -57,15 +61,15 @@ function Test-PowerShellGalleryAccess {
         # The API key validation can be done by attempting to access the API
         try {
             Write-Verbose 'Testing API connectivity...'
-            
+
             # Try to access the API root to validate connectivity
             $apiUrl = $contextObj.ApiUrl
             $headers = @{
                 'X-NuGet-ApiKey' = $apiKey
             }
 
-            # Test basic API access
-            $response = Invoke-RestMethod -Uri $apiUrl -Method Get -Headers $headers -ErrorAction Stop
+            # Test basic API access - just verify we can connect
+            $null = Invoke-RestMethod -Uri $apiUrl -Method Get -Headers $headers -ErrorAction Stop
 
             $result = [PSCustomObject]@{
                 Success     = $true