Aircraft MovementZone/SpeedType fix allows landable aircraft to land on water by default

[Starkku]

Description

Debatable how much of a bug this is but at the very least it is a default behaviour change that is not mentioned in migration section currently.

Presumably due to the change introduced in 0.4 with using AircraftType's actual MovementZone and SpeedType for landing zone checks (hook FootClass_IsLandZoneClear_ReplaceHardcode), Landable=true AircraftTypes that are not AirportBound can freely land on water as they please assuming their SpeedType has not been changed to one that prevents this (Aircraft usually don't declare SpeedType which uses default value of Winged which allows all land types to be traversed). One could consider this an expected outcome of the fix but it is also generally undesirable and currently entirely undocumented.

At a glance the previous behaviour and behaviour after if explicitly setting SpeedType=Track or something is basically identical, although this will also restore the original 'issue' of being unable to order such aircraft on water at all.

As a note, landable jumpjet vehicles with SpeedType that allows traversing water will not land on water as likely some part of the jumpjet locomotor processing blocks this, doesn't appear to be the same for fly locomotor.

Phobos Version

0.4

Conditions to reproduce

No response

INI code

[SOMEAIRCRAFT]
...
MovementZone=Fly
SpeedType=Winged
AirportBound=no
Landable=yes

Steps to reproduce

1. Acquire aircraft with Landable=no and AirportBound=no in game.
2. Order said aircraft on a body of water.
3. Watch as the aircraft comfortably lands on water.

Expected behaviour

1. Aircraft refuses to land on water.

OR

1. This change in behaviour is documented.

Actual behaviour

1. Landable aircraft now land on water, modders are not informed of this change in documentation.

Additional context

0.4 is first stable release with this issue, present in some pre-0.4 dev builds as well.

Checklist

• The issue happens on the latest official version of Phobos and wasn't fixed yet.
• I agree to elaborate the details if requested and provide thorough testing if the bugfix is implemented.
• I added a very descriptive title to this issue.
• I used the GitHub search and read the issue list to find a similar issue and didn't find it.
• I have attached as much information as possible (screenshots, gifs, videos, debug and exception logs, etc).

[DeathFishAtEase]

Additionally, the improvement method of this fix needs to consider the Carryall logic. The original fix allowed AircraftTypes to apply the Carryall logic to ships in water. For AircraftTypes that use this logic, being able to land on water is actually reasonable and necessary.

[Starkku]

Carryalls seem to be able to pick up vehicles from water even if their SpeedType disallows movement on water. Atleast currently.

[DeathFishAtEase]

Without this fix, because Aircraft always resets the destination to the shore, it is impossible to place ships in the water; instead, they can only be placed on land and explode.

[yawnallday]

The original behavior of Ares' aircraft Carryalls was that the aircraft would automatically seek nearby land for landing, which would result in the towed naval vehicle exploding upon landing on the ground. After modifications by PHOBOS, the aircraft can now dock on the water surface. If a ground vehicle is being towed at this time, both the aircraft and the ground vehicle will sink and explode.