Missing Trade Encounters

[notblisy]

The API is missing a lot of trade encounters, what I've noticed so far is:

All RBY trades are missing.

• https://bulbapedia.bulbagarden.net/wiki/In-game_trade#Pok%C3%A9mon_Red_and_Green_(Japan),_Pok%C3%A9mon_Red_and_Blue_(Western)

All GSC Trades are missing:

• https://bulbapedia.bulbagarden.net/wiki/In-game_trade#Generation_II

All RSE Trades are missing:

• https://bulbapedia.bulbagarden.net/wiki/In-game_trade#Generation_II

All FRLG Trades are missing:

• https://bulbapedia.bulbagarden.net/wiki/In-game_trade#Generation_II

All G4 Trades are missing in HGSS and DPPt:

• https://bulbapedia.bulbagarden.net/wiki/In-game_trade#Generation_IV

All G5 Trades are missing in BW and B2W2:

• https://bulbapedia.bulbagarden.net/wiki/In-game_trade#Generation_V

All G6 Trades are missing in XY/ORAS:

• https://bulbapedia.bulbagarden.net/wiki/In-game_trade#Generation_VI

Gen 7 is the only gen with encounters that actually has the NPC trades, and it has them for both LGPE and SM/USUM!

Obviously they're missing in gens 8/9 as well, but there's currently no encounter data at all for them yet in the API anyway.

In addition to this, as discussed in my PR for Pokemon XD: Gale of Darkness, I think we should be add a new Encounter_Condition in Encounter_Conditions.csv called Trade.

And then, when adding NPC-Trade encounters to the API, we should add an encounter condition for each one that says what Pokemon to trade for them, and what the NPCs name is if they're named. Let's use Mimien the Mr. Mime as an example:

• 108,15,trade-REYLEY-abra,0

This notes which NPC to trade with and which Pokemon to give them. We would have to go back and add the conditions for the gen 7 pokemon trades as well.

Lastly, I do think it's important to have this data in the API. Certain Pokemon are only catchable in games via trade from an NPC, such as Mr Mime, Farfech'd, and a few others.

Things I think this issue should not cover:

• Trading for a Pokemon with another real gameboy

That is a much bigger task, out of scope with the NPC-Trade encounter_method, and also solvable by the end user.

Currently I'm working on a website with a friend and we can have the site display trade or transfer from X game just by using logic to deduce if the Pokemon is in the selected game or not, and what is the nearest game you could receive it from, so I don't think it's necessary to include in the API at all.

As with any issue like this I bring up, I'm of course willing to do the work and write down all these encounters. I would probably do 1 PR per gen as to not make a massive PR with like 85 trade pokemon from 7 regions and 10 games.

I would start with gen 1 and work my way up, but if anyone is interested in doing any of these I'd ask you post here so we don't both do the same gen at once!