feedback OB

Author: MariusMerkleQC

diffly/_conditions.py

@@ -3,6 +3,7 @@
 
 import datetime as dt
 from collections.abc import Mapping
+from typing import cast
 
 import polars as pl
 from polars.datatypes import DataType, DataTypeClass
@@ -206,12 +207,7 @@ def _compare_sequence_columns(
         n_elements = dtype_right.shape[0]
         has_same_length = col_left.list.len().eq(pl.lit(n_elements))
     else:  # pl.List vs pl.List
-        if max_list_length is None:
-            raise ValueError(
-                "max_list_length must be provided for List-vs-List comparisons "
-                "in _compare_sequence_columns()."
-            )
-        n_elements = max_list_length
+        n_elements = cast(int, max_list_length)
         has_same_length = col_left.list.len().eq_missing(col_right.list.len())
 
     if n_elements == 0:

tests/test_conditions.py

@@ -512,34 +512,6 @@ def test_condition_equal_columns_lists_only_inner() -> None:
     assert actual.to_list() == [True, False]
 
 
-def test_condition_equal_columns_two_lists_no_max_length() -> None:
-    lhs = pl.DataFrame(
-        {
-            "pk": [1, 2],
-            "a_left": [[1.0, 2.0], [3.0, 4.0]],
-        },
-    )
-    rhs = pl.DataFrame(
-        {
-            "pk": [1, 2],
-            "a_right": [[1.0, 2.0], [3.0, 4.0]],
-        },
-    )
-
-    with pytest.raises(
-        ValueError,
-        match="max_list_length must be provided for List-vs-List comparisons",
-    ):
-        lhs.join(rhs, on="pk", maintain_order="left").select(
-            condition_equal_columns(
-                "a",
-                dtype_left=lhs.schema["a_left"],
-                dtype_right=rhs.schema["a_right"],
-                max_list_length=None,
-            )
-        ).to_series()
-
-
 @pytest.mark.parametrize(
     ("dtype_left", "dtype_right", "can_compare_dtypes"),
     [