From 74def71cc64f91ac6a96ef700e2f1327dd07772c Mon Sep 17 00:00:00 2001 From: Katharine Hyatt Date: Thu, 26 Feb 2026 07:42:06 -0500 Subject: [PATCH 1/2] Get rid of non-existent type --- Project.toml | 2 +- ext/StridedViewsAMDGPUExt.jl | 2 +- test/runtests.jl | 12 ++++++++---- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/Project.toml b/Project.toml index b335bde..72f3c7e 100644 --- a/Project.toml +++ b/Project.toml @@ -1,7 +1,7 @@ name = "StridedViews" uuid = "4db3bf67-4bd7-4b4e-b153-31dc3fb37143" authors = ["Lukas Devos ", "Jutho Haegeman "] -version = "0.4.4" +version = "0.4.5" [deps] LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e" diff --git a/ext/StridedViewsAMDGPUExt.jl b/ext/StridedViewsAMDGPUExt.jl index c15a112..01f75ec 100644 --- a/ext/StridedViewsAMDGPUExt.jl +++ b/ext/StridedViewsAMDGPUExt.jl @@ -2,7 +2,7 @@ module StridedViewsAMDGPUExt using StridedViews using AMDGPU -using AMDGPU: Adapt, ROCPtr +using AMDGPU: Adapt const ROCStridedView{T, N, A <: ROCArray{T}} = StridedView{T, N, A} diff --git a/test/runtests.jl b/test/runtests.jl index 6e46933..056f70c 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -304,11 +304,13 @@ using CUDA, AMDGPU if CUDA.functional() @testset "CuArrays with StridedView" begin @testset for T in (Float64, ComplexF64) - A = CUDA.randn!(T, 10, 10, 10, 10) + A = CuArray(randn(T, 10, 10, 10, 10)) @test isstrided(A) B = StridedView(A) @test B isa StridedView - @test B == A + CUDA.@allowscalar begin + @test B == A + end end end end @@ -316,11 +318,13 @@ end if AMDGPU.functional() @testset "ROCArrays with StridedView" begin @testset for T in (Float64, ComplexF64) - A = AMDGPU.randn!(T, 10, 10, 10, 10) + A = ROCArray(randn(T, 10, 10, 10, 10)) @test isstrided(A) B = StridedView(A) @test B isa StridedView - @test B == A + AMDGPU.@allowscalar begin + @test B == A + end end end end From 0ca319167496798f0953e2b47d29d4f5a0941881 Mon Sep 17 00:00:00 2001 From: Katharine Hyatt Date: Thu, 26 Feb 2026 08:50:15 -0500 Subject: [PATCH 2/2] Test fix --- test/runtests.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/runtests.jl b/test/runtests.jl index 056f70c..36cc38e 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -304,7 +304,7 @@ using CUDA, AMDGPU if CUDA.functional() @testset "CuArrays with StridedView" begin @testset for T in (Float64, ComplexF64) - A = CuArray(randn(T, 10, 10, 10, 10)) + A = CUDA.randn(T, 10, 10, 10, 10) @test isstrided(A) B = StridedView(A) @test B isa StridedView