Fix update_list

Testing of `unpack_with`

Author: VirxEC

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "rlbot_flatbuffers"
-version = "0.14.0"
+version = "0.14.1"
 edition = "2024"
 description = "A Python module implemented in Rust for serializing and deserializing RLBot's flatbuffers"
 repository = "https://github.com/VirxEC/rlbot_flatbuffers_py"

Cargo.toml

@@ -159,6 +159,30 @@ def random_script_config():
     data = ballPred.pack()
     print(f"BallPrediction size: {len(data)} bytes")
 
+    # verify unpack_with method
+    emptyBallPred = BallPrediction()
+    data = emptyBallPred.pack()
+
+    ballPred.unpack_with(data)
+    assert len(ballPred.slices) == 0
+
+    fullBallPred = BallPrediction([PredictionSlice(t / 120) for t in range(6 * 120)])
+    data = fullBallPred.pack()
+
+    ballPred.unpack_with(data)
+    assert len(ballPred.slices) == 6 * 120
+
+    halfBallPred = BallPrediction(
+        [PredictionSlice(t / 120 + 1) for t in range(3 * 120)]
+    )
+    data = halfBallPred.pack()
+
+    ballPred.unpack_with(data)
+    assert len(ballPred.slices) == 3 * 120
+
+    for i, slice in enumerate(ballPred.slices):
+        assert slice.game_seconds - (i / 120 + 1) < 1e-6
+
     print()
 
     print("Running quick benchmark...")

pytest.py

@@ -15,7 +15,10 @@ pub mod generated;
 #[allow(clippy::enum_variant_names, clippy::useless_conversion, unused_imports)]
 mod python;
 
-use pyo3::{PyClass, create_exception, exceptions::PyValueError, prelude::*, types::*};
+use pyo3::{
+    PyClass, create_exception, exceptions::PyValueError, prelude::*,
+    pyclass::boolean_struct::False, types::*,
+};
 use python::*;
 use std::{panic::Location, path::MAIN_SEPARATOR};
 
@@ -144,9 +147,7 @@ pub trait UnpackFrom<T> {
 pub fn update_list<T, U>(py: Python, items: Borrowed<PyList>, flat_t: Vec<T>)
 where
     T: IntoGil<U>,
-    U: pyo3::PyClass<Frozen = pyo3::pyclass::boolean_struct::False>
-        + Into<PyClassInitializer<U>>
-        + UnpackFrom<T>,
+    U: pyo3::PyClass<Frozen = False> + Into<PyClassInitializer<U>> + UnpackFrom<T>,
 {
     let scripts_len = flat_t.len();
     let mut script_iter = flat_t.into_iter();
@@ -159,8 +160,9 @@ where
                 .borrow_mut()
                 .unpack_from(py, item),
             None => {
-                for i in scripts_len..items.len() {
-                    items.del_item(i).unwrap();
+                let items_len = items.len();
+                for i in 0..items_len - scripts_len {
+                    items.del_item(items_len - i - 1).unwrap();
                 }
                 return;
             }