-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Open
Labels
issue: feature requestDescribes a new feature and why it should be addedDescribes a new feature and why it should be addedissue: triageIssues awaiting triage by a Blockly team memberIssues awaiting triage by a Blockly team member
Description
Check for duplicates
- I have searched for similar issues before opening a new one.
Problem
No response
Request
core/renderers/zelos/path_object.ts needs some changes in updateSelected to ensure that the duplicated selection object doesn't unintentionally inherit ARIA properties from its reference path object (since this can cause problems in the accessibility node tree). This is done by, rather than cloning the path object and removing elements ('denylisting'), a new SVG is created with only select elements defined ('allowlisting'):
- class: set to 'blocklyPath blocklyPathSelected'.
- stroke: set to svgPath's stroke or default to empty string.
- fill: set to svgPath's fill or default to empty string.
- d: set to svgPath's d property or default to empty string.
- role: set to PRESENTATION (since neither it nor any of its possible children should ever be part of the accessibility node graph).
The new element should still be made a child of svgRoot.
Alternatives considered
No response
Additional context
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
issue: feature requestDescribes a new feature and why it should be addedDescribes a new feature and why it should be addedissue: triageIssues awaiting triage by a Blockly team memberIssues awaiting triage by a Blockly team member
Type
Projects
Status
Todo