Skip Salesforce integration specs when Heroku Connect DB is unavailable

Step 1:

Tag all three Salesforce job specs with requires_salesforce_db: true.
Add a filter_run_excluding rule in rails_helper so these specs are
automatically skipped when SALESFORCE_CONNECT_DB is not set (i.e. the
developer is running tests locally without the heroku-connect Docker
service).

CI and Docker environments, which set SALESFORCE_CONNECT_DB, continue
to run the full Salesforce spec suite unchanged.

Step 2:

Make SALESFORCE_ENABLED opt-in (default false)

Previously salesforce_sync? returned true unless SALESFORCE_ENABLED was
explicitly set to 'false'. This caused GoodJob (which runs inline in
test mode) to execute SchoolSyncJob and RoleSyncJob immediately whenever
a school or role was created in any test — hitting Salesforce tables that
don't exist in the test database.

Change the check to opt-in: salesforce_sync? now returns true only when
SALESFORCE_ENABLED == 'true'. Production and Docker setups already set
this explicitly, so behaviour there is unchanged.

Update the model specs to set SALESFORCE_ENABLED=true for the describe
block that asserts jobs are enqueued, and update the feature flags spec
to reflect the new default-false behaviour.

Step 3:

Guard after_commit callbacks with feature flag condition

Move the FeatureFlags.salesforce_sync? check (and the student? check
for Role) from inside do_salesforce_sync into the after_commit :if
condition. This prevents the callback from firing at all when Salesforce
sync is disabled, avoiding any interaction with the queue adapter or
Salesforce models in tests that don't enable the feature.

Author: fspeirs

app/models/role.rb

@@ -16,7 +16,7 @@ class Role < ApplicationRecord
     }
   )
 
-  after_commit :do_salesforce_sync, on: %i[create update]
+  after_commit :do_salesforce_sync, on: %i[create update], if: -> { FeatureFlags.salesforce_sync? && !student? }
 
   private
 
@@ -42,9 +42,6 @@ def users_can_only_have_roles_in_one_school
   end
 
   def do_salesforce_sync
-    return unless FeatureFlags.salesforce_sync?
-    return if student? # We never sync student roles to Salesforce
-
     Salesforce::RoleSyncJob.perform_later(role_id: id)
   end
 end

app/models/school.rb

@@ -55,7 +55,7 @@ class School < ApplicationRecord
 
   after_create :generate_code!
 
-  after_commit :do_salesforce_sync, on: %i[create update]
+  after_commit :do_salesforce_sync, on: %i[create update], if: -> { FeatureFlags.salesforce_sync? }
 
   def self.find_for_user!(user)
     school = Role.find_by(user_id: user.id)&.school || find_by(creator_id: user.id, rejected_at: nil)
@@ -174,8 +174,6 @@ def format_uk_postal_code
   end
 
   def do_salesforce_sync
-    return unless FeatureFlags.salesforce_sync?
-
     Salesforce::SchoolSyncJob.perform_later(school_id: id)
     Salesforce::ContactSyncJob.perform_later(school_id: id)
   end

lib/feature_flags.rb

@@ -6,6 +6,6 @@ def self.immediate_school_onboarding?
   end
 
   def self.salesforce_sync?
-    ENV['SALESFORCE_ENABLED'] != 'false'
+    ENV['SALESFORCE_ENABLED'] == 'true'
   end
 end

spec/jobs/salesforce/contact_sync_job_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rails_helper'
 
-RSpec.describe Salesforce::ContactSyncJob do
+RSpec.describe Salesforce::ContactSyncJob, requires_salesforce_db: true do
   subject(:perform_job) { described_class.perform_now(school_id: school.id) }
 
   let(:school) { create(:school, creator_agree_to_ux_contact: true) }

spec/jobs/salesforce/role_sync_job_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rails_helper'
 
-RSpec.describe Salesforce::RoleSyncJob do
+RSpec.describe Salesforce::RoleSyncJob, requires_salesforce_db: true do
   subject(:perform_job) { described_class.perform_now(role_id: role.id) }
 
   let(:role) { create(:role) }

spec/jobs/salesforce/school_sync_job_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rails_helper'
 
-RSpec.describe Salesforce::SchoolSyncJob do
+RSpec.describe Salesforce::SchoolSyncJob, requires_salesforce_db: true do
   subject(:perform_job) { described_class.perform_now(school_id: school.id) }
 
   let(:school) { create(:school) }

spec/lib/feature_flags_spec.rb

@@ -36,9 +36,9 @@
   end
 
   describe '.salesforce_sync?' do
-    it 'returns true when ENV is not set' do
+    it 'returns false when ENV is not set' do
       ClimateControl.modify(SALESFORCE_ENABLED: nil) do
-        expect(described_class.salesforce_sync?).to be(true)
+        expect(described_class.salesforce_sync?).to be(false)
       end
     end
 

spec/models/role_spec.rb

@@ -167,6 +167,10 @@
   end
 
   describe 'salesforce sync' do
+    around do |example|
+      ClimateControl.modify(SALESFORCE_ENABLED: 'true') { example.run }
+    end
+
     it 'enqueues a Salesforce::RoleSyncJob on create' do
       expect { create(:role) }.to have_enqueued_job(Salesforce::RoleSyncJob)
     end

spec/models/school_spec.rb

@@ -629,6 +629,10 @@
   end
 
   describe 'salesforce sync' do
+    around do |example|
+      ClimateControl.modify(SALESFORCE_ENABLED: 'true') { example.run }
+    end
+
     it 'enqueues Salesforce::SchoolSyncJob on create' do
       expect { create(:school) }.to have_enqueued_job(Salesforce::SchoolSyncJob)
     end

spec/rails_helper.rb

@@ -72,6 +72,10 @@
     metadata[:type] = :graphql_query
   end
 
+  # Salesforce integration specs require the Heroku Connect service (i.e. SALESFORCE_CONNECT_DB
+  # must be set). Skip them automatically when running locally without the service.
+  config.filter_run_excluding requires_salesforce_db: true unless ENV.key?('SALESFORCE_CONNECT_DB')
+
   # Filter lines from Rails gems in backtraces.
   config.filter_rails_from_backtrace!
   # arbitrary gems may also be filtered via: