Fix /0 subnet bug. Remove example code from unittest.

Author: RobThree

IPNetworkHelper.Tests/IPNetworkHelperTests.cs

@@ -42,17 +42,17 @@ public void TryParsePrefixMustBeNetworkIPv6()
         public void TryParsePrefixLengthMustBeValid()
         {
             Assert.IsFalse(IPNetworkHelper.TryParse("192.168.0.0/33", out var _));  // Should fail, max is 32
-            Assert.IsFalse(IPNetworkHelper.TryParse("0.0.0.0/0", out var _));  // Should fail, min is 1
+            Assert.IsFalse(IPNetworkHelper.TryParse("0.0.0.0/-1", out var _));  // Should fail, min is 0
 
             Assert.IsFalse(IPNetworkHelper.TryParse("DEAD:BEEF:0:1234::/129", out var _));  // Should fail, max is 128
-            Assert.IsFalse(IPNetworkHelper.TryParse("0::0/0", out var _));    // Should fail, min is 1
+            Assert.IsFalse(IPNetworkHelper.TryParse("0::0/-1", out var _));    // Should fail, min is 0
 
             // These should all pass since they're at the limits (min/max)
             Assert.IsTrue(IPNetworkHelper.TryParse("192.168.0.0/32", out var _));
-            Assert.IsTrue(IPNetworkHelper.TryParse("0.0.0.0/1", out var _));
+            Assert.IsTrue(IPNetworkHelper.TryParse("0.0.0.0/0", out var _));
 
             Assert.IsTrue(IPNetworkHelper.TryParse("DEAD:BEEF:0:0:1234:5678:90AB:CDEF/128", out var _));
-            Assert.IsTrue(IPNetworkHelper.TryParse("0::0/1", out var _));
+            Assert.IsTrue(IPNetworkHelper.TryParse("0::0/0", out var _));
         }
 
         [TestMethod]
@@ -167,41 +167,6 @@ public void HasValidPrefix()
 
             Assert.IsTrue(IPNetworkHelper.HasValidPrefix(n1));
             Assert.IsFalse(IPNetworkHelper.HasValidPrefix(n2));
-
-            // Parse a network, throws on invalid networks
-            var network = IPNetworkHelper.Parse("192.168.0.0/16");
-            
-            // Tries to parse, returns true when succeeded, false otherwise and the parsed network
-            if (IPNetworkHelper.TryParse("192.168.0.0/16", out var othernetwork))
-            {
-                // ...
-            }
-
-            // Get first/last IP from network
-            var first = network.GetFirstIP();   // Network      (192.168.0.0)
-            var last = network.GetLastIP();     // Broadcast    (192.168.255.255)
-
-            // Splits a network into two halves
-            var (left, right) = network.Split();    // Returns 192.168.0.0/17 and 192.168.128.0/17
-
-            // Remove a subnet from a network
-            var desired = IPNetworkHelper.Parse("192.168.10.16/28");
-            var result = network.Extract(desired);
-
-            // Result:
-            // 192.168.0.0/21
-            // 192.168.8.0/23
-            // 192.168.10.0/28
-            // 192.168.10.16/28
-            // 192.168.10.32/27
-            // 192.168.10.64/26
-            // 192.168.10.128/25
-            // 192.168.11.0/24
-            // 192.168.12.0/22
-            // 192.168.16.0/20
-            // 192.168.32.0/19
-            // 192.168.64.0/18
-            // 192.168.128.0/17
         }
     }
 }

IPNetworkHelper/IPNetworkHelper.cs

@@ -74,7 +74,7 @@ internal static byte[] CalculateLastBytes(byte[] prefixBytes, int prefixLength)
         }
 
         private static bool IsValidPrefixLength(byte[] prefixBytes, int prefixLength)
-            => prefixLength <= prefixBytes.Length * 8 && prefixLength > 0;
+            => prefixLength <= prefixBytes.Length * 8 && prefixLength >= 0;
 
         private static byte[] CreateMask(byte[] prefixBytes, int prefixLength)
         {

IPNetworkHelper/IPNetworkHelper.csproj

@@ -15,7 +15,8 @@
     <RepositoryUrl>https://github.com/RobThree/IPNetworkHelper</RepositoryUrl>
     <RepositoryType>git</RepositoryType>
     <PackageTags>networking, csharp, ipv6, dotnet, network, ipv4, ip, cidr, extension-methods, dotnet-standard, ipv6-network, cidr-notation, ipv6-subnetting, ipv4-subnetting, ipv4-network, cidr-subnet</PackageTags>
-    <PackageReleaseNotes>Initial release</PackageReleaseNotes>
+    <PackageReleaseNotes>Fix /0 subnet bug.</PackageReleaseNotes>
+    <Version>1.0.1</Version>
   </PropertyGroup>
 
   <ItemGroup>