-
-
Notifications
You must be signed in to change notification settings - Fork 94
Closed
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
I spent some time reviewing the new webpack-based approach for the Runestone Components to ensure all the images are correctly included. I see two problems we need to address:
- The clock image used for timed questions doesn't render properly. I think it would be best to assign this to a style, then add CSS to reference the image directly. See all instances of
../_static/clock.pngin thetimed_xxx.jsfiles, and the source image inrunestone/common/project_template/_static. I'd suggest moving this torunestone/common/cssthen modifying the CSS these. - The play overlay icon at https://github.com/RunestoneInteractive/RunestoneComponents/blob/master/runestone/common/js/bookfuncs.js#L285. This relies on web2py templates to render, so it's already a non-starter for pretext. Again, put this in CSS then just set a style, I would think.
I'm not aware of any other missing images.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed