Merge pull request #39 from SOFTNETWORK-APP/fix/failureRate

fupelaqu · web-flow · commit d953e386d9fd · 2026-03-10T16:20:29.000+01:00
Metrics - Fix failure rate calculation to handle zero total operations Closed Issue #40
diff --git a/build.sbt b/build.sbt
@@ -20,7 +20,7 @@ ThisBuild / organization := "app.softnetwork"
 
 name := "softclient4es"
 
-ThisBuild / version := "0.17.3"
+ThisBuild / version := "0.17-SNAPSHOT"
 
 ThisBuild / scalaVersion := scala213
 
diff --git a/core/src/main/scala/app/softnetwork/elastic/client/metrics/OperationMetrics.scala b/core/src/main/scala/app/softnetwork/elastic/client/metrics/OperationMetrics.scala
@@ -32,5 +32,5 @@ case class OperationMetrics(
   def successRate: Double =
     if (totalOperations > 0) (successCount.toDouble / totalOperations) * 100 else 0.0
 
-  def failureRate: Double = 100.0 - successRate
+  def failureRate: Double = if (totalOperations > 0) 100.0 - successRate else 0.0
 }

Original file line number	Diff line number	Diff line change
`@@ -32,5 +32,5 @@ case class OperationMetrics(`
`32`	`32`	`def successRate: Double =`
`33`	`33`	`if (totalOperations > 0) (successCount.toDouble / totalOperations) * 100 else 0.0`
`34`	`34`
`35`		`- def failureRate: Double = 100.0 - successRate`
	`35`	`+ def failureRate: Double = if (totalOperations > 0) 100.0 - successRate else 0.0`
`36`	`36`	`}`