fix: Actually rename post instead of creating new one, when item is renamed (#4)

Author: Sanielia

src/bot.py

@@ -1,5 +1,6 @@
 import asyncio
 import os
+import shelve
 
 from hikari import GuildPublicThread, RESTApp, TokenType
 from hikari.impl import RESTClientImpl
@@ -81,10 +82,16 @@ async def create_post(
         f" Link do taska: {create_item_link(event.item_id)}"
     )
     async with shared_forum_channel.lock.reader_lock:
-        return await client.create_forum_post(
+        post = await client.create_forum_post(
             shared_forum_channel.forum_channel,
             item_name,
             message,
             auto_archive_duration=10080,
             user_mentions=user_mentions,
         )
+
+    with shelve.open(os.getenv("POST_ID_DB_PATH", "post_id.db")) as db:
+        db[event.node_id] = str(post.id)
+        print("meow", db)
+
+    return post

src/tests/test_e2e.py

@@ -94,7 +94,7 @@ async def test_e2e(
         await asyncio.sleep(0.01)
     else:
         pytest.fail("Expected log 'body updated' not found in output")
-    assert post_id_shelf.get("audacity4") == 621
+    assert post_id_shelf.get("audacity4") == "621"
     mock_create_message.assert_called_with(
         621, "Opis taska zaktualizowany przez: nieznany użytkownik. Nowy opis: \nUpdated description", user_mentions=[]
     )

src/tests/test_unit/test_bot.py

@@ -7,27 +7,34 @@
 from hikari.impl import RESTClientImpl
 
 from src import bot
-from src.tests.conftest import RestClientContextManagerMock
+from src.tests.conftest import MockShelf, RestClientContextManagerMock
 from src.utils.data_types import SimpleProjectItemEvent
 from src.utils.error import ForumChannelNotFound
 
 
+@patch("shelve.open")
 @patch("src.bot.fetch_item_name", new_callable=AsyncMock)
 @patch.object(RESTClientImpl, "create_forum_post", new_callable=AsyncMock)
 async def test_create_post(
     mock_create_forum_post,
     mock_fetch_item_name,
+    mock_shelve_open,
     rest_client_mock,
     shared_forum_channel_mock,
     user_text_mention,
+    post_mock,
 ):
     mock_fetch_item_name.return_value = "audacity4"
+    mock_shelf = MockShelf()
+    mock_shelve_open.return_value = mock_shelf
+    mock_create_forum_post.return_value = post_mock
     message = f"Nowy task stworzony audacity4 przez: {user_text_mention}.\n Link do taska: https://github.com/orgs/my-org/projects/1?pane=issue&item_id=1"
     event = SimpleProjectItemEvent(1, "audacity4", "norbiros", "created")
     await bot.create_post(event, user_text_mention, shared_forum_channel_mock, rest_client_mock, [])
     mock_create_forum_post.assert_called_with(
         shared_forum_channel_mock.forum_channel, event.node_id, message, auto_archive_duration=10080, user_mentions=[]
     )
+    assert mock_shelf.get("audacity4") == "621"
 
 
 @patch("src.bot.create_post", new_callable=AsyncMock)

src/tests/test_unit/test_utils/test_discord_rest_client.py

@@ -62,7 +62,7 @@ async def test_get_post_id_active_thread(
     mock_fetch_item_name.return_value = "audacity4"
 
     assert await discord_rest_client.get_post_id_or_post("node_id", 1, 1, rest_client_mock) == post_mock
-    assert mock_shelf.get("audacity4") == 621
+    assert mock_shelf.get("audacity4") == "621"
 
 
 @patch("src.utils.discord_rest_client.fetch_item_name", new_callable=AsyncMock)
@@ -84,7 +84,7 @@ async def test_get_post_id_archived_thread(
     mock_fetch_item_name.return_value = "audacity4"
 
     assert await discord_rest_client.get_post_id_or_post("node_id", 1, 1, rest_client_mock) == post_mock
-    assert mock_shelf.get("audacity4") == 621
+    assert mock_shelf.get("audacity4") == "621"
 
 
 @patch("src.utils.discord_rest_client.fetch_item_name", new_callable=AsyncMock)

src/utils/discord_rest_client.py

@@ -31,11 +31,11 @@ async def get_post_id_or_post(
         name = await fetch_item_name(node_id)
         for thread in await rest_client.fetch_active_threads(discord_guild_id):
             if thread.name == name:
-                db[name] = thread.id
+                db[name] = str(thread.id)
                 return thread
         for thread in await rest_client.fetch_public_archived_threads(forum_channel_id):
             if thread.name == name:
-                db[name] = thread.id
+                db[name] = str(thread.id)
                 return thread
 
     return None