ZR crashes in competitive gamemode

[Vauff]

Seems to crash within CPhysicsGameSystem::OnSimulate, the stacktraces don't directly blame our code, so debugging this is challenging. The CS2F stacktrace reference is just our GameFrame hook.

https://crash.limetech.org/tbgk63nfdanz
https://crash.limetech.org/77eyuvs5k56f

Workarounds:

• Run casual game_mode 0
• Disable hibernation sv_hibernate_when_empty 0; sv_hibernate_postgame_delay 9999999999999999

[Vauff]

After further investigation, this is happening because our cvar enforcement code doesn't execute in time due to hibernation delaying the one tick timer:

CS2Fixes/src/zombiereborn.cpp

Lines 833 to 835 in 750a8a4

	// Necessary to fix bots kicked/joining infinitely when forced to CT https://github.com/Source2ZE/ZombieReborn/issues/64
	g_pEngineServer2->ServerCommand("bot_quota_mode fill");
	g_pEngineServer2->ServerCommand("mp_autoteambalance 0");

gamemode_competitive.cfg sets bot_quota_mode competitive which triggers the crash in this case. It's also worth noting that this forceteams interaction causing crashes is new info, previously it was only known to cause bots being kicked/joining infinitely.

[CS2ModServer]

Read Access Violation

If anyone stumbles in here with the server appearing to load everything successfully and inexplicably crashing at the end, this thread helped.

"bot_quota_mode fill" being added to my gamemode_competative_server.cfg stopped the crashing.