-
-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Description
Description
After #85, monorepo detection in validate and edit-package-json commands does not recognize pnpm-workspace.yaml. This causes:
-
commands/validate.ts:isInsideMonorepo()only walks up checkingpackage.jsonworkspaces fields — pnpm monorepos usingpnpm-workspace.yaml(without aworkspacesfield in package.json) are missed, producing false!skills/_artifactspackaging warnings. -
setup.tsrunEditPackageJson(): Has the same blind spot in its inline monorepo detection IIFE — it incorrectly adds!skills/_artifactsto thefilesarray for pnpm monorepo packages.
Expected Behavior
Both commands should detect monorepos via findWorkspaceRoot() → readWorkspacePatterns(), which already handles pnpm-workspace.yaml, package.json workspaces, and other formats.
Reproduction
- Create a pnpm monorepo with
pnpm-workspace.yaml(noworkspacesfield in rootpackage.json) - Add skills to a workspace package
- Run
intent validate packages/<pkg>/skills— observe false!skills/_artifactswarning - Run
intent edit-package-jsonfrom a workspace package — observe!skills/_artifactsincorrectly added tofiles
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels