From fc62e1acd55c2d31d14e4e60a59969e9d4cc4a3e Mon Sep 17 00:00:00 2001
From: Wonsuk Choi <sukvvon@gmail.com>
Date: Sat, 28 Mar 2026 21:48:54 +0900
Subject: [PATCH] test(preact-query): apply 'prefer-template',
 'no-else-return', 'object-shorthand', 'radix', and 'require-await' eslint
 rules

---
 .../src/__tests__/useMutationState.test.tsx   |  2 +-
 .../usePrefetchInfiniteQuery.test.tsx         |  2 +-
 .../src/__tests__/useQueries.test.tsx         | 24 ++++++------
 .../src/__tests__/useQuery.test.tsx           | 38 +++++++++----------
 .../src/__tests__/useSuspenseQueries.test.tsx |  6 +--
 .../src/__tests__/useSuspenseQuery.test.tsx   |  1 -
 6 files changed, 35 insertions(+), 38 deletions(-)

diff --git a/packages/preact-query/src/__tests__/useMutationState.test.tsx b/packages/preact-query/src/__tests__/useMutationState.test.tsx
index c8097326486..8618a5d9fd3 100644
--- a/packages/preact-query/src/__tests__/useMutationState.test.tsx
+++ b/packages/preact-query/src/__tests__/useMutationState.test.tsx
@@ -206,7 +206,7 @@ describe('useMutationState', () => {
     function Mutate() {
       const { mutate, data } = useMutation({
         mutationKey,
-        mutationFn: (input: number) => sleep(150).then(() => 'data' + input),
+        mutationFn: (input: number) => sleep(150).then(() => `data${input}`),
       })
 
       return (
diff --git a/packages/preact-query/src/__tests__/usePrefetchInfiniteQuery.test.tsx b/packages/preact-query/src/__tests__/usePrefetchInfiniteQuery.test.tsx
index a62c2ff16cf..f87cb2a2204 100644
--- a/packages/preact-query/src/__tests__/usePrefetchInfiniteQuery.test.tsx
+++ b/packages/preact-query/src/__tests__/usePrefetchInfiniteQuery.test.tsx
@@ -25,7 +25,7 @@ const generateInfiniteQueryOptions = (
       .mockImplementation(async () => {
         const currentPageData = data[currentPage]
         if (!currentPageData) {
-          throw new Error('No data defined for page ' + currentPage)
+          throw new Error(`No data defined for page ${currentPage}`)
         }
 
         await sleep(10)
diff --git a/packages/preact-query/src/__tests__/useQueries.test.tsx b/packages/preact-query/src/__tests__/useQueries.test.tsx
index d0a77bca025..7b6b59c6996 100644
--- a/packages/preact-query/src/__tests__/useQueries.test.tsx
+++ b/packages/preact-query/src/__tests__/useQueries.test.tsx
@@ -190,7 +190,7 @@ describe('useQueries', () => {
             queryFn: () => 'string',
             select: (a) => {
               expectTypeOf(a).toEqualTypeOf<string>()
-              return parseInt(a)
+              return parseInt(a, 10)
             },
           },
         ],
@@ -219,7 +219,7 @@ describe('useQueries', () => {
             queryFn: () => 'string',
             select: (a) => {
               expectTypeOf(a).toEqualTypeOf<string>()
-              return parseInt(a)
+              return parseInt(a, 10)
             },
             placeholderData: 'string',
             // @ts-expect-error (initialData: string)
@@ -302,7 +302,7 @@ describe('useQueries', () => {
             queryFn: () => 'string',
             select: (a) => {
               expectTypeOf(a).toEqualTypeOf<string>()
-              return parseInt(a)
+              return parseInt(a, 10)
             },
           },
         ],
@@ -362,7 +362,7 @@ describe('useQueries', () => {
             queryFn: () => 'string',
             select: (a) => {
               expectTypeOf(a).toEqualTypeOf<string>()
-              return parseInt(a)
+              return parseInt(a, 10)
             },
             placeholderData: 'string',
             // @ts-expect-error (initialData: string)
@@ -404,7 +404,7 @@ describe('useQueries', () => {
             queryFn: () => 'string',
             select: (a) => {
               expectTypeOf(a).toEqualTypeOf<string>()
-              return parseInt(a)
+              return parseInt(a, 10)
             },
           }),
         ],
@@ -556,7 +556,7 @@ describe('useQueries', () => {
           {
             queryKey: key4,
             queryFn: () => 'string',
-            select: (a: string) => parseInt(a),
+            select: (a: string) => parseInt(a, 10),
           },
           {
             queryKey: key5,
@@ -596,12 +596,12 @@ describe('useQueries', () => {
           {
             queryKey: key4,
             queryFn: () => 'string',
-            select: (a: string) => parseInt(a),
+            select: (a: string) => parseInt(a, 10),
           },
           {
             queryKey: key5,
             queryFn: () => 'string',
-            select: (a: string) => parseInt(a),
+            select: (a: string) => parseInt(a, 10),
             throwOnError,
           },
         ],
@@ -1138,14 +1138,14 @@ describe('useQueries', () => {
               queryKey: key1,
               queryFn: async () => {
                 await sleep(5)
-                return Promise.resolve('first result ' + count)
+                return Promise.resolve(`first result ${count}`)
               },
             },
             {
               queryKey: key2,
               queryFn: async () => {
                 await sleep(50)
-                return Promise.resolve('second result ' + count)
+                return Promise.resolve(`second result ${count}`)
               },
             },
           ],
@@ -1330,14 +1330,14 @@ describe('useQueries', () => {
               queryKey: key1,
               queryFn: async () => {
                 await sleep(10)
-                return 'first result:' + value
+                return `first result:${value}`
               },
             },
             {
               queryKey: key2,
               queryFn: async () => {
                 await sleep(20)
-                return 'second result:' + value
+                return `second result:${value}`
               },
             },
           ],
diff --git a/packages/preact-query/src/__tests__/useQuery.test.tsx b/packages/preact-query/src/__tests__/useQuery.test.tsx
index c9bfd6a61cb..ae7676a941c 100644
--- a/packages/preact-query/src/__tests__/useQuery.test.tsx
+++ b/packages/preact-query/src/__tests__/useQuery.test.tsx
@@ -473,7 +473,7 @@ describe('useQuery', () => {
         queryKey: key,
         queryFn: async () => {
           await sleep(10)
-          return 'data: ' + value
+          return `data: ${value}`
         },
 
         gcTime: 0,
@@ -769,7 +769,7 @@ describe('useQuery', () => {
         queryFn: async () => {
           await sleep(10)
           count++
-          return 'test' + count
+          return `test${count}`
         },
       })
 
@@ -3686,9 +3686,8 @@ describe('useQuery', () => {
           if (counter < 2) {
             counter++
             return Promise.reject(new Error('error'))
-          } else {
-            return Promise.resolve('data')
           }
+          return Promise.resolve('data')
         },
         retryDelay: 10,
       })
@@ -5062,9 +5061,8 @@ describe('useQuery', () => {
           await sleep(10)
           if (id % 2 === 1) {
             return Promise.reject(new Error('Error'))
-          } else {
-            return 'data'
           }
+          return 'data'
         },
         retry: false,
         retryOnMount: false,
@@ -5300,7 +5298,7 @@ describe('useQuery', () => {
           queryFn: async () => {
             count++
             await sleep(10)
-            return 'data' + count
+            return `data${count}`
           },
         })
 
@@ -5363,7 +5361,7 @@ describe('useQuery', () => {
           queryFn: async () => {
             count++
             await sleep(10)
-            return 'data' + count
+            return `data${count}`
           },
         })
 
@@ -5411,7 +5409,7 @@ describe('useQuery', () => {
           queryFn: async () => {
             count++
             await sleep(10)
-            return 'data' + count
+            return `data${count}`
           },
         })
 
@@ -5457,7 +5455,7 @@ describe('useQuery', () => {
           queryFn: async () => {
             count++
             await sleep(10)
-            return 'data' + count
+            return `data${count}`
           },
           initialData: 'initial',
         })
@@ -5505,7 +5503,7 @@ describe('useQuery', () => {
           queryFn: async () => {
             count++
             await sleep(10)
-            return 'data' + count
+            return `data${count}`
           },
           initialData: 'initial',
         })
@@ -5565,7 +5563,7 @@ describe('useQuery', () => {
           queryFn: async (): Promise<unknown> => {
             count++
             await sleep(10)
-            throw new Error('failed' + count)
+            throw new Error(`failed${count}`)
           },
           retry: 2,
           retryDelay: 10,
@@ -5678,7 +5676,7 @@ describe('useQuery', () => {
           queryFn: async () => {
             count++
             await sleep(10)
-            return 'data' + count
+            return `data${count}`
           },
         })
 
@@ -5735,7 +5733,7 @@ describe('useQuery', () => {
           queryFn: async () => {
             count++
             await sleep(10)
-            return 'data' + count
+            return `data${count}`
           },
           refetchOnReconnect: false,
         })
@@ -5787,7 +5785,7 @@ describe('useQuery', () => {
       function Component() {
         const state = useQuery({
           queryKey: key,
-          queryFn: async () => {
+          queryFn: () => {
             count++
             return `data${count}`
           },
@@ -5862,7 +5860,7 @@ describe('useQuery', () => {
           queryFn: async () => {
             count++
             await sleep(10)
-            return 'data ' + count
+            return `data ${count}`
           },
           networkMode: 'always',
         })
@@ -5898,7 +5896,7 @@ describe('useQuery', () => {
           queryFn: async (): Promise<unknown> => {
             count++
             await sleep(10)
-            throw new Error('error ' + count)
+            throw new Error(`error ${count}`)
           },
           networkMode: 'always',
           retry: 1,
@@ -5942,7 +5940,7 @@ describe('useQuery', () => {
           queryFn: async (): Promise<unknown> => {
             count++
             await sleep(10)
-            throw new Error('failed' + count)
+            throw new Error(`failed${count}`)
           },
           retry: 2,
           retryDelay: 1,
@@ -6067,7 +6065,7 @@ describe('useQuery', () => {
         renders++
         return (
           <div>
-            <span>{data ? 'has data' + data : 'no data'}</span>
+            <span>{data ? `has data${data}` : 'no data'}</span>
             <button
               onClick={() => queryClient.setQueryData<string>(key, 'new data')}
             >
@@ -6697,7 +6695,7 @@ describe('useQuery', () => {
     expect(results[3]).toMatchObject({
       status: 'error',
       fetchStatus: 'idle',
-      error: error,
+      error,
       errorUpdateCount: 2,
       isLoading: false,
       failureCount: 1,
diff --git a/packages/preact-query/src/__tests__/useSuspenseQueries.test.tsx b/packages/preact-query/src/__tests__/useSuspenseQueries.test.tsx
index 80e956035c0..5445fa95b0d 100644
--- a/packages/preact-query/src/__tests__/useSuspenseQueries.test.tsx
+++ b/packages/preact-query/src/__tests__/useSuspenseQueries.test.tsx
@@ -500,7 +500,7 @@ describe('useSuspenseQueries 2', () => {
     function Page({ count, isPending }: { count: number; isPending: boolean }) {
       const { data } = useSuspenseQuery({
         queryKey: [key, count],
-        queryFn: () => sleep(10).then(() => 'data' + count),
+        queryFn: () => sleep(10).then(() => `data${count}`),
       })
 
       return <div>{isPending ? 'pending' : data}</div>
@@ -560,7 +560,7 @@ describe('useSuspenseQueries 2', () => {
         queryFn: () =>
           sleep(10).then(() => {
             queryFnCount++
-            return 'data' + count
+            return `data${count}`
           }),
       })
 
@@ -601,7 +601,7 @@ describe('useSuspenseQueries 2', () => {
     function Page({ count, isPending }: { count: number; isPending: boolean }) {
       const { data } = useSuspenseQuery({
         queryKey: [key, count],
-        queryFn: () => sleep(10).then(() => 'data' + count),
+        queryFn: () => sleep(10).then(() => `data${count}`),
       })
 
       return (
diff --git a/packages/preact-query/src/__tests__/useSuspenseQuery.test.tsx b/packages/preact-query/src/__tests__/useSuspenseQuery.test.tsx
index eb165ca4709..fd38f84915e 100644
--- a/packages/preact-query/src/__tests__/useSuspenseQuery.test.tsx
+++ b/packages/preact-query/src/__tests__/useSuspenseQuery.test.tsx
@@ -918,7 +918,6 @@ describe('useSuspenseQuery', () => {
       useSuspenseQuery({
         queryKey: key,
         // @ts-expect-error
-        // eslint-disable-next-line
         queryFn: Math.random() >= 0 ? skipToken : () => Promise.resolve(5),
       })