Skip to content

Commit f911be5

Browse files
committed
fix: Don't error when passing too new warning flags to old clang.
Older macOS versions with older xcode versions with older clang versions don't have these warning flags. On newer ones, we do need those suppressions. Alternative would be to detect support, but in this case, we don't really care to be extremely clean.
1 parent e64fa0c commit f911be5

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

qtox/build_qtbase_macos.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ fi
4545

4646
# We want -Werror to catch warnings related to macOS version compatibility.
4747
# We silence unused-variable because disabling features (like filesystemwatcher) can leave variables unused in Qt's source.
48-
sed -i '' -e 's/-Wextra/-Wextra -Werror "-Wno-#warnings" -Wno-cast-function-type-mismatch -Wno-deprecated-declarations -Wno-unused-but-set-variable -Wno-unused-variable -Wno-vla-cxx-extension/' cmake/QtCompilerFlags.cmake
48+
sed -i '' -e 's/-Wextra/-Wextra -Werror -Wno-unknown-warning-option "-Wno-#warnings" -Wno-cast-function-type-mismatch -Wno-deprecated-declarations -Wno-unused-but-set-variable -Wno-unused-variable -Wno-vla-cxx-extension/' cmake/QtCompilerFlags.cmake
4949

5050
mkdir _build && pushd _build
5151
../configure \

0 commit comments

Comments
 (0)