From eba4ddf98af181424ca8f6f3db67039a7f6f9a2b Mon Sep 17 00:00:00 2001 From: Andreas Rossberg Date: Tue, 30 Sep 2025 08:05:02 +0200 Subject: [PATCH 1/3] [ci] Disable JS tests again --- .github/workflows/ci-interpreter.yml | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci-interpreter.yml b/.github/workflows/ci-interpreter.yml index 6edfa0c4..1a7511ff 100644 --- a/.github/workflows/ci-interpreter.yml +++ b/.github/workflows/ci-interpreter.yml @@ -23,12 +23,17 @@ jobs: with: ocaml-compiler: 4.12.x - name: Setup OCaml tools - run: opam install --yes ocamlbuild.0.14.0 ocamlfind.1.9.5 js_of_ocaml.4.0.0 js_of_ocaml-ppx.4.0.0 - - name: Setup Node.js - uses: actions/setup-node@v2 - with: - node-version: 19.x + run: opam install --yes ocamlfind.1.9.5 js_of_ocaml.4.0.0 js_of_ocaml-ppx.4.0.0 - name: Build interpreter run: cd interpreter && opam exec make + # Neither V8 nor SpiderMonkey can currently handle all 3.0 tests, so we disable checking JS translation for now. + #- name: Setup Node.js + # uses: actions/setup-node@v4 + # with: + # node-version: 25-nightly + #- name: Setup SpiderMonkey + # run: curl -O https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/jsshell-linux-x86_64.zip && unzip jsshell-linux-x86_64.zip - name: Run tests - run: cd interpreter && opam exec make JS=node ci + run: cd interpreter && opam exec make ci # don't test JS translation + # run: cd interpreter && opam exec make JS=node ci # test with V8 + # run: cd interpreter && opam exec make JS=../js ci # test with SM From 9eae252c06b6b182cf3bea7825add06497e0593a Mon Sep 17 00:00:00 2001 From: stevenfontanella Date: Mon, 9 Feb 2026 22:45:38 +0000 Subject: [PATCH 2/3] Use setup-ocaml@v3 --- .github/workflows/ci-interpreter.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-interpreter.yml b/.github/workflows/ci-interpreter.yml index 1a7511ff..6ca5db55 100644 --- a/.github/workflows/ci-interpreter.yml +++ b/.github/workflows/ci-interpreter.yml @@ -19,7 +19,7 @@ jobs: - name: Checkout repo uses: actions/checkout@v2 - name: Setup OCaml - uses: ocaml/setup-ocaml@v2 + uses: ocaml/setup-ocaml@v3 with: ocaml-compiler: 4.12.x - name: Setup OCaml tools From af539d8020cc73697c5e71e906e79fa90feae94d Mon Sep 17 00:00:00 2001 From: stevenfontanella Date: Mon, 9 Feb 2026 23:51:16 +0000 Subject: [PATCH 3/3] Fix race in os.makedirs --- test/core/run.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/core/run.py b/test/core/run.py index 2aa93b30..517b705f 100755 --- a/test/core/run.py +++ b/test/core/run.py @@ -113,8 +113,7 @@ def _runTestFile(self, inputPath): if __name__ == "__main__": - if not os.path.exists(outputDir): - os.makedirs(outputDir) + os.makedirs(outputDir, exist_ok=True) for fileName in inputFiles: testName = 'test ' + os.path.basename(fileName) setattr(RunTests, testName, lambda self, file=fileName: self._runTestFile(file))