Skip to content

Commit 6cb2b6c

Browse files
bokelleyclaude
bokelley
and
claude
authored
feat: sync upstream schemas from PR 1252 (#139)
* feat: sync upstream schemas and expose new API types - Synced 315 schemas from adcontextprotocol.org (61 updated, 10 new) - Regenerated Pydantic models from updated schemas - Added backward compat stubs for removed types: DeliverTo, DeliverTo1, Pricing - Exposed new public types: GetAccountFinancialsRequest/Response, ReportUsageRequest/Response, SyncAudiencesRequest/Response, GetCreativeFeaturesRequest/Response, CpaPricingOption, TimeBasedPricingOption, TimeUnit, SignalPricing, SignalPricingOption, OptimizationGoal, CreativeVariant, ArtifactWebhookPayload - Added aliases for new discriminated union responses - Updated tests for schema breaking changes (account/buying_mode now required) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: export missing public API types and clarify compat stubs Add AccountReference, Overlay, CatalogFieldMapping, CatalogFieldBinding, and Transform to the public API - all were used as field types in exported request/response types but were not directly importable. Add AccountReferenceById / AccountReferenceByNaturalKey aliases for the two identification methods (by seller-assigned ID vs. brand+operator natural key). Clarify DeliverTo/Pricing compat stub comments: the GetSignalsRequest wire format changed (deliver_to.deployments+countries → top-level destinations+countries), so the stubs preserve import compatibility only and cannot restore the old request behavior. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: address expert review findings - complete public API surface From code and ad tech expert reviews: 1. Add CpaPricingOption + TimeBasedPricingOption to PricingOption union (they were exported individually but omitted from the union alias) 2. Add SignalPricingOption variant aliases: CpmSignalPricingOption, PercentOfMediaSignalPricingOption, FlatFeeSignalPricingOption (consistent with other discriminated union pattern in aliases.py) 3. Export SyncAudiencesAudience + ConsentBasis for SyncAudiencesRequest construction (same pattern as SyncCreativeResult, SyncCatalogResult) 4. Expose all new/missing types from adcp top-level package: AccountReference, CpaPricingOption, TimeBasedPricingOption, TimeUnit, SignalPricing, SignalPricingOption, GetAccountFinancialsRequest/Response, ReportUsageRequest/Response, SyncAudiencesRequest/Response, GetCreativeFeaturesRequest/Response, CreativeVariant, ArtifactWebhookPayload, OptimizationGoal, CatalogFieldMapping, CatalogFieldBinding, Overlay, Transform, ConsentBasis, SyncCreativeResult 5. Fix __init__.py docstring: correct module reference (_ergonomic not coercion), restore "never import from generated_poc" architectural note Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: sync upstream schemas (PR 1252), add backward compat, address review Sync 315 upstream schemas (61 updated, 10 new) from adcontextprotocol/adcp PR 1252 which fixed 17 schema gaps and 7 consistency issues. Key changes: - Regenerate all types from updated schemas - Add backward compat aliases for pricing renames (CpmAuction/Fixed -> Cpm) - Add backward compat aliases for activation key renames (PropertyId -> SegmentId) - Add backward compat aliases for preview request renames (Format -> Single) - Add compat stubs for removed types (ListAuthorizedProperties, PackageStatus) - Fix SyncAudiencesAudience pointing at wrong Audience type (name collision) - Add new semantic aliases (GetProductsBriefRequest, GetSignalsDiscoveryRequest, etc.) - Export new enums (BuyingMode, MediaChannel, DeviceType, etc.) - Export new models (PaginationRequest, BrandReference, Proposal, etc.) - Re-export DeliverTo, Pricing, Measurement from top-level adcp package - Fix stale stable.py reference in consolidate_exports template - Fix lint violations in consolidate_exports.py Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: address critical review findings for PR #139 - Fix silent Status type shadowing: override with MediaBuyDeliveryStatus (delivery status was silently swapped to invoice status due to alphabetical module sort order in _generated.py) - Add CatalogGroupBinding semantic alias for CatalogFieldBinding1 - Add 19 missing types to adcp.__all__ (AccountScope, BuyingMode, AudienceSource, CreativeApprovalStatus, DevicePlatform, DeviceType, EventType, MediaChannel, WcagLevel, ContextObject, ExtensionObject, PaginationRequest, Proposal, BrandReference, DateRange, DatetimeRange, Duration, ErrorCode, Refine) - Remove duplicate PercentOfMediaSignalPricingOption from adcp.__all__ - Move Measurement, DeliverTo, Pricing to backward-compat section - Add 31 backward-compat alias tests covering all 13+ deprecated names - Strengthen weak assertion in test_str_returns_pydantic_default Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: resolve mypy error for Status type override Import Status directly from delivery response module instead of reassigning, which mypy rejects as incompatible type assignment. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent a08805d commit 6cb2b6c

269 files changed

Lines changed: 10550 additions & 1874 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎schemas/cache/.hashes.json‎

Lines changed: 121 additions & 98 deletions
Large diffs are not rendered by default.

‎schemas/cache/account/get-account-financials-request.json‎

Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
{
2+
"$schema": "http://json-schema.org/draft-07/schema#",
3+
"additionalProperties": true,
4+
"description": "Request financial status for an operator-billed account. Returns spend summary, credit/balance status, and invoice history. Only applicable when the seller declares account_financials capability.",
5+
"examples": [
6+
{
7+
"data": {
8+
"account": {
9+
"account_id": "acc_acme_001"
10+
}
11+
},
12+
"description": "Query by account ID for current billing cycle"
13+
},
14+
{
15+
"data": {
16+
"account": {
17+
"brand": {
18+
"domain": "acme-corp.com"
19+
},
20+
"operator": "acme-corp.com"
21+
},
22+
"period": {
23+
"end": "2026-01-31",
24+
"start": "2026-01-01"
25+
}
26+
},
27+
"description": "Query by natural key for a specific period"
28+
},
29+
{
30+
"data": {
31+
"account": {
32+
"brand": {
33+
"brand_id": "spark",
34+
"domain": "nova-brands.com"
35+
},
36+
"operator": "pinnacle-media.com"
37+
}
38+
},
39+
"description": "Agency querying financials for a client account"
40+
}
41+
],
42+
"properties": {
43+
"account": {
44+
"$ref": "../core/account-ref.json",
45+
"description": "Account to query financials for. Must be an operator-billed account."
46+
},
47+
"context": {
48+
"$ref": "../core/context.json"
49+
},
50+
"ext": {
51+
"$ref": "../core/ext.json"
52+
},
53+
"period": {
54+
"$ref": "../core/date-range.json",
55+
"description": "Date range for the spend summary. Defaults to the current billing cycle if omitted."
56+
}
57+
},
58+
"required": [
59+
"account"
60+
],
61+
"title": "Get Account Financials Request",
62+
"type": "object"
63+
}

‎schemas/cache/account/get-account-financials-response.json‎

Lines changed: 319 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,319 @@
1+
{
2+
"$schema": "http://json-schema.org/draft-07/schema#",
3+
"description": "Financial status for an operator-billed account. Returns spend summary, credit/balance status, payment status, and invoice history. The level of detail varies by seller \u2014 only account, currency, and period are guaranteed on success.",
4+
"examples": [
5+
{
6+
"data": {
7+
"account": {
8+
"account_id": "acc_acme_001"
9+
},
10+
"credit": {
11+
"available_credit": 54770.0,
12+
"credit_limit": 100000.0,
13+
"utilization_percent": 45.23
14+
},
15+
"currency": "USD",
16+
"invoices": [
17+
{
18+
"amount": 38500.0,
19+
"due_date": "2026-02-28",
20+
"invoice_id": "inv_2026_01",
21+
"paid_date": "2026-02-15",
22+
"period": {
23+
"end": "2026-01-31",
24+
"start": "2026-01-01"
25+
},
26+
"status": "paid"
27+
}
28+
],
29+
"payment_status": "current",
30+
"payment_terms": "net_30",
31+
"period": {
32+
"end": "2026-02-28",
33+
"start": "2026-02-01"
34+
},
35+
"spend": {
36+
"media_buy_count": 3,
37+
"total_spend": 45230.0
38+
},
39+
"timezone": "America/New_York"
40+
},
41+
"description": "Credit account \u2014 current, with invoice history"
42+
},
43+
{
44+
"data": {
45+
"account": {
46+
"brand": {
47+
"domain": "acme-corp.com"
48+
},
49+
"operator": "acme-corp.com"
50+
},
51+
"balance": {
52+
"available": 1800.0,
53+
"last_top_up": {
54+
"amount": 10000.0,
55+
"date": "2026-02-01"
56+
}
57+
},
58+
"currency": "USD",
59+
"payment_status": "current",
60+
"payment_terms": "prepay",
61+
"period": {
62+
"end": "2026-02-28",
63+
"start": "2026-02-01"
64+
},
65+
"spend": {
66+
"media_buy_count": 2,
67+
"total_spend": 8200.0
68+
},
69+
"timezone": "America/Los_Angeles"
70+
},
71+
"description": "Prepay account with low balance"
72+
},
73+
{
74+
"data": {
75+
"errors": [
76+
{
77+
"code": "UNSUPPORTED_FEATURE",
78+
"message": "Financial data is not available for agent-billed accounts. The agent's own billing system is the source of truth."
79+
}
80+
]
81+
},
82+
"description": "Agent-billed account \u2014 not supported"
83+
}
84+
],
85+
"oneOf": [
86+
{
87+
"additionalProperties": true,
88+
"description": "Financial data retrieved successfully",
89+
"not": {
90+
"required": [
91+
"errors"
92+
]
93+
},
94+
"properties": {
95+
"account": {
96+
"$ref": "../core/account-ref.json",
97+
"description": "Account reference, echoed from the request"
98+
},
99+
"balance": {
100+
"description": "Prepay balance. Present for prepay accounts.",
101+
"properties": {
102+
"available": {
103+
"description": "Remaining prepaid balance",
104+
"minimum": 0,
105+
"type": "number"
106+
},
107+
"last_top_up": {
108+
"description": "Most recent balance top-up",
109+
"properties": {
110+
"amount": {
111+
"description": "Top-up amount",
112+
"minimum": 0,
113+
"type": "number"
114+
},
115+
"date": {
116+
"description": "Date of top-up",
117+
"format": "date",
118+
"type": "string"
119+
}
120+
},
121+
"required": [
122+
"amount",
123+
"date"
124+
],
125+
"type": "object"
126+
}
127+
},
128+
"required": [
129+
"available"
130+
],
131+
"type": "object"
132+
},
133+
"context": {
134+
"$ref": "../core/context.json"
135+
},
136+
"credit": {
137+
"description": "Credit status. Present for credit-based accounts (payment_terms like net_30).",
138+
"properties": {
139+
"available_credit": {
140+
"description": "Remaining credit available (credit_limit minus outstanding balance)",
141+
"type": "number"
142+
},
143+
"credit_limit": {
144+
"description": "Maximum outstanding balance allowed",
145+
"minimum": 0,
146+
"type": "number"
147+
},
148+
"utilization_percent": {
149+
"description": "Credit utilization as a percentage (0-100)",
150+
"maximum": 100,
151+
"minimum": 0,
152+
"type": "number"
153+
}
154+
},
155+
"required": [
156+
"credit_limit",
157+
"available_credit"
158+
],
159+
"type": "object"
160+
},
161+
"currency": {
162+
"description": "ISO 4217 currency code for all monetary amounts in this response",
163+
"pattern": "^[A-Z]{3}$",
164+
"type": "string"
165+
},
166+
"ext": {
167+
"$ref": "../core/ext.json"
168+
},
169+
"invoices": {
170+
"description": "Recent invoices. Sellers may limit the number returned.",
171+
"items": {
172+
"properties": {
173+
"amount": {
174+
"description": "Invoice total in currency",
175+
"minimum": 0,
176+
"type": "number"
177+
},
178+
"due_date": {
179+
"description": "Payment due date",
180+
"format": "date",
181+
"type": "string"
182+
},
183+
"invoice_id": {
184+
"description": "Seller-assigned invoice identifier",
185+
"type": "string"
186+
},
187+
"paid_date": {
188+
"description": "Date payment was received. Present when status is 'paid'.",
189+
"format": "date",
190+
"type": "string"
191+
},
192+
"period": {
193+
"$ref": "../core/date-range.json",
194+
"description": "Billing period covered by this invoice"
195+
},
196+
"status": {
197+
"description": "Invoice status",
198+
"enum": [
199+
"draft",
200+
"issued",
201+
"paid",
202+
"past_due",
203+
"void"
204+
],
205+
"type": "string"
206+
}
207+
},
208+
"required": [
209+
"invoice_id",
210+
"amount",
211+
"status"
212+
],
213+
"type": "object"
214+
},
215+
"type": "array"
216+
},
217+
"payment_status": {
218+
"description": "Overall payment status. current: all obligations met. past_due: one or more invoices overdue. suspended: account suspended due to payment issues.",
219+
"enum": [
220+
"current",
221+
"past_due",
222+
"suspended"
223+
],
224+
"type": "string"
225+
},
226+
"payment_terms": {
227+
"description": "Payment terms in effect (e.g., 'net_30', 'prepay')",
228+
"type": "string"
229+
},
230+
"period": {
231+
"$ref": "../core/date-range.json",
232+
"description": "The actual period covered by spend data. May differ from the requested period if the seller adjusts to billing cycle boundaries."
233+
},
234+
"spend": {
235+
"description": "Spend summary for the period",
236+
"properties": {
237+
"media_buy_count": {
238+
"description": "Number of active media buys in the period",
239+
"minimum": 0,
240+
"type": "integer"
241+
},
242+
"total_spend": {
243+
"description": "Total spend in the period, in currency",
244+
"minimum": 0,
245+
"type": "number"
246+
}
247+
},
248+
"required": [
249+
"total_spend"
250+
],
251+
"type": "object"
252+
},
253+
"timezone": {
254+
"description": "IANA timezone of the seller's billing day boundaries (e.g., 'America/New_York'). All dates in this response \u2014 period, invoice periods, due dates \u2014 are calendar dates in this timezone. Buyers in a different timezone should expect spend boundaries to differ from their own calendar day.",
255+
"type": "string"
256+
}
257+
},
258+
"required": [
259+
"account",
260+
"currency",
261+
"period",
262+
"timezone"
263+
],
264+
"title": "GetAccountFinancialsSuccess",
265+
"type": "object"
266+
},
267+
{
268+
"additionalProperties": true,
269+
"description": "Operation failed \u2014 financials not available",
270+
"not": {
271+
"anyOf": [
272+
{
273+
"required": [
274+
"account"
275+
]
276+
},
277+
{
278+
"required": [
279+
"currency"
280+
]
281+
},
282+
{
283+
"required": [
284+
"period"
285+
]
286+
},
287+
{
288+
"required": [
289+
"timezone"
290+
]
291+
}
292+
]
293+
},
294+
"properties": {
295+
"context": {
296+
"$ref": "../core/context.json"
297+
},
298+
"errors": {
299+
"description": "Operation-level errors",
300+
"items": {
301+
"$ref": "../core/error.json"
302+
},
303+
"minItems": 1,
304+
"type": "array"
305+
},
306+
"ext": {
307+
"$ref": "../core/ext.json"
308+
}
309+
},
310+
"required": [
311+
"errors"
312+
],
313+
"title": "GetAccountFinancialsError",
314+
"type": "object"
315+
}
316+
],
317+
"title": "Get Account Financials Response",
318+
"type": "object"
319+
}

‎schemas/cache/account/list-accounts-request.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
"enum": [
2222
"active",
2323
"pending_approval",
24+
"rejected",
2425
"payment_required",
2526
"suspended",
2627
"closed"

0 commit comments

Comments
 (0)