Skip to content

feat: add url_type to click_url assets and remove click_tracker #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BaiyuScope3 merged 2 commits into from
Feb 12, 2026
Merged

feat: add url_type to click_url assets and remove click_tracker #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
968d0a2
feat: add url_type to click_url assets and remove click_tracker
BaiyuScope3 Feb 12, 2026
0dd9262
test: remove obsolete click_tracker tests
BaiyuScope3 Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 17 additions & 89 deletions src/creative_agent/data/standard_formats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,19 +83,19 @@ def create_impression_tracker_asset() -> LibAssets:
)


def create_click_tracker_asset() -> LibAssets:
"""Create an optional click tracker asset for 3rd party tracking.
def create_click_url_asset() -> LibAssets:
"""Create a required clickthrough URL asset.

This creates a URL asset with url_type='tracker_redirect' that can be used
for third-party click tracking redirects.
This creates a URL asset with url_type='clickthrough' for the landing page
destination when users click on the ad.
"""
return create_asset(
asset_id="click_tracker",
asset_id="click_url",
asset_type=AssetType.url,
required=False,
required=True,
requirements={
"url_type": "tracker_redirect",
"description": "3rd party click tracking redirect URL",
"url_type": "clickthrough",
"description": "Clickthrough destination URL",
},
)

Expand Down Expand Up @@ -173,7 +173,6 @@ def create_responsive_render(
requirements={"description": "Text prompt describing the desired creative"},
),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
# Concrete formats for backward compatibility
Expand All @@ -199,7 +198,6 @@ def create_responsive_render(
requirements={"description": "Text prompt describing the desired creative"},
),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
CreativeFormat(
Expand All @@ -224,7 +222,6 @@ def create_responsive_render(
requirements={"description": "Text prompt describing the desired creative"},
),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
CreativeFormat(
Expand All @@ -249,7 +246,6 @@ def create_responsive_render(
requirements={"description": "Text prompt describing the desired creative"},
),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
CreativeFormat(
Expand All @@ -274,7 +270,6 @@ def create_responsive_render(
requirements={"description": "Text prompt describing the desired creative"},
),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
CreativeFormat(
Expand All @@ -299,7 +294,6 @@ def create_responsive_render(
requirements={"description": "Text prompt describing the desired creative"},
),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
CreativeFormat(
Expand All @@ -324,7 +318,6 @@ def create_responsive_render(
requirements={"description": "Text prompt describing the desired creative"},
),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
CreativeFormat(
Expand All @@ -349,7 +342,6 @@ def create_responsive_render(
requirements={"description": "Text prompt describing the desired creative"},
),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
]
Expand Down Expand Up @@ -411,7 +403,6 @@ def create_responsive_render(
asset_type=AssetType.vast,
required=True,
),
create_click_tracker_asset(),
],
),
# Concrete formats for backward compatibility
Expand Down Expand Up @@ -470,7 +461,6 @@ def create_responsive_render(
"description": "VAST 4.x compatible tag",
},
),
create_click_tracker_asset(),
],
),
CreativeFormat(
Expand Down Expand Up @@ -623,16 +613,8 @@ def create_responsive_render(
"acceptable_formats": ["jpg", "png", "gif", "webp"],
},
),
create_asset(
asset_id="click_url",
asset_type=AssetType.url,
required=True,
requirements={
"description": "Clickthrough destination URL",
},
),
create_click_url_asset(),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
# Concrete formats for backward compatibility
Expand All @@ -655,16 +637,8 @@ def create_responsive_render(
"acceptable_formats": ["jpg", "png", "gif", "webp"],
},
),
create_asset(
asset_id="click_url",
asset_type=AssetType.url,
required=True,
requirements={
"description": "Clickthrough destination URL",
},
),
create_click_url_asset(),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
CreativeFormat(
Expand All @@ -686,13 +660,8 @@ def create_responsive_render(
"acceptable_formats": ["jpg", "png", "gif", "webp"],
},
),
create_asset(
asset_id="click_url",
asset_type=AssetType.url,
required=True,
),
create_click_url_asset(),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
CreativeFormat(
Expand All @@ -714,13 +683,8 @@ def create_responsive_render(
"acceptable_formats": ["jpg", "png", "gif", "webp"],
},
),
create_asset(
asset_id="click_url",
asset_type=AssetType.url,
required=True,
),
create_click_url_asset(),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
CreativeFormat(
Expand All @@ -742,13 +706,8 @@ def create_responsive_render(
"acceptable_formats": ["jpg", "png", "gif", "webp"],
},
),
create_asset(
asset_id="click_url",
asset_type=AssetType.url,
required=True,
),
create_click_url_asset(),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
CreativeFormat(
Expand All @@ -770,13 +729,8 @@ def create_responsive_render(
"acceptable_formats": ["jpg", "png", "gif", "webp"],
},
),
create_asset(
asset_id="click_url",
asset_type=AssetType.url,
required=True,
),
create_click_url_asset(),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
CreativeFormat(
Expand All @@ -798,13 +752,8 @@ def create_responsive_render(
"acceptable_formats": ["jpg", "png", "gif", "webp"],
},
),
create_asset(
asset_id="click_url",
asset_type=AssetType.url,
required=True,
),
create_click_url_asset(),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
CreativeFormat(
Expand All @@ -826,13 +775,8 @@ def create_responsive_render(
"acceptable_formats": ["jpg", "png", "gif", "webp"],
},
),
create_asset(
asset_id="click_url",
asset_type=AssetType.url,
required=True,
),
create_click_url_asset(),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
]
Expand All @@ -858,7 +802,6 @@ def create_responsive_render(
},
),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
# Concrete formats for backward compatibility
Expand All @@ -882,7 +825,6 @@ def create_responsive_render(
},
),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
CreativeFormat(
Expand All @@ -904,7 +846,6 @@ def create_responsive_render(
},
),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
CreativeFormat(
Expand All @@ -926,7 +867,6 @@ def create_responsive_render(
},
),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
CreativeFormat(
Expand All @@ -948,7 +888,6 @@ def create_responsive_render(
},
),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
CreativeFormat(
Expand All @@ -970,7 +909,6 @@ def create_responsive_render(
},
),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
CreativeFormat(
Expand All @@ -992,7 +930,6 @@ def create_responsive_render(
},
),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
]
Expand All @@ -1015,7 +952,6 @@ def create_responsive_render(
required=True,
),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
]
Expand Down Expand Up @@ -1119,14 +1055,7 @@ def create_responsive_render(
"description": "Author name for editorial context",
},
),
create_asset(
asset_id="click_url",
asset_type=AssetType.url,
required=True,
requirements={
"description": "Landing page URL",
},
),
create_click_url_asset(),
create_asset(
asset_id="disclosure",
asset_type=AssetType.text,
Expand All @@ -1136,7 +1065,6 @@ def create_responsive_render(
},
),
create_impression_tracker_asset(),
create_click_tracker_asset(),
],
),
]
Expand Down
Loading