From b80b84e8662717c814e4c307fd4e1df9d2124120 Mon Sep 17 00:00:00 2001 From: debianed <62648606+debianed@users.noreply.github.com> Date: Thu, 26 Feb 2026 18:22:26 +0700 Subject: [PATCH 1/2] Update CMakeLists.txt Typo in line 84: CMake Warning (dev) in src/adldap/CMakeLists.txt: A logical block opening on the line admc/src/adldap/CMakeLists.txt:67 (if) closes on the line admc/src/adldap/CMakeLists.txt:84 (endif) with mis-matching arguments. This warning is for project developers. Use -Wno-dev to suppress it. --- src/adldap/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/adldap/CMakeLists.txt b/src/adldap/CMakeLists.txt index 2b37d8f1..349df755 100644 --- a/src/adldap/CMakeLists.txt +++ b/src/adldap/CMakeLists.txt @@ -81,7 +81,7 @@ if (EXISTS ${VERSION_H}) DESTINATION ${SMB_SRC_PATH}) file(COPY ${SMB_SRC_PATH}/src_older/ndr_sec_helper.c DESTINATION ${SMB_SRC_PATH}) - endif(VERSION_SMB_MINOR GREATER_EQUAL 20) + endif(VERSION_SMB_MINOR GREATER_EQUAL 22) else() message(WARNING "Failed to find Samba version. If its version is 20 or greater, use sources from src_4_20.") endif(EXISTS ${VERSION_H}) From 40d0618225e1a349d344f68fc88891b9082ea506 Mon Sep 17 00:00:00 2001 From: debianed <62648606+debianed@users.noreply.github.com> Date: Fri, 27 Feb 2026 09:25:37 +0700 Subject: [PATCH 2/2] Update krb5client.cpp Fixes an unexpected admc shutdown without first running kinit --- src/adldap/krb5client.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/adldap/krb5client.cpp b/src/adldap/krb5client.cpp index b4a64af2..d6d5f1f8 100644 --- a/src/adldap/krb5client.cpp +++ b/src/adldap/krb5client.cpp @@ -228,7 +228,7 @@ void Krb5Client::Krb5ClientImpl::load_caches() { void Krb5Client::Krb5ClientImpl::load_cache_data(krb5_ccache ccache, bool is_system) { krb5_error_code res; - krb5_principal principal; + krb5_principal principal = nullptr; krb5_creds creds; Krb5TGTData tgt_data;