Skip to content

Releases from non-default branch are tagged incorrectly #167

@emrekultursay

Description

@emrekultursay

I did the releases 2.0.0, 2.0.1, and 2.0.2 using the following command:

gh workflow run release.yml --ref idea-251

Which checked out the idea-251 branch, and then built it (this is in build.yml). Thus, the platform binaries are correct.

In the next step, the release process invoked the Create Release step, which uses the softprops/action-gh-release@v2 action.

However, we didn't pass the branch/commit information to that step, so it tagged the tip-of-tree of the main branch.

That's why, if we navigate to the Releases page (e.g., https://github.com/android-graphics/sherlock-platform/releases/tag/v2.0.2), the commit and tag both point to the wrong place.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions