fix review

Author: HeartLinked

.github/workflows/rc.yml

@@ -31,11 +31,10 @@ jobs:
   archive:
     name: Archive
     runs-on: ubuntu-latest
-    timeout-minutes: 5 # Can be reduced as we are not checking out submodules
+    timeout-minutes: 5
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-        # No longer need 'with: { submodules: 'recursive' }'
 
       - name: Prepare for tag
         if: github.ref_type == 'tag'
@@ -53,7 +52,6 @@ jobs:
           id="apache-iceberg-cpp-${VERSION}-rc${RC}"
           tar_gz="${id}.tar.gz"
           echo "TAR_GZ=${tar_gz}" >> ${GITHUB_ENV}
-          # Reverted to the git archive command from the Go implementation
           git archive HEAD --prefix "${id}/" --output "${tar_gz}"
           sha512sum "${tar_gz}" > "${tar_gz}.sha512"
 
@@ -78,7 +76,6 @@ jobs:
         os:
           - macos-latest
           - ubuntu-latest
-          # Consider adding windows-latest if your project supports it
           # - windows-latest
     steps:
       - name: Install C++ Build Tools (Ubuntu)
@@ -112,9 +109,9 @@ jobs:
           fi
           echo "VERSION=${version}"
           echo "RC=${rc}"
-          # You MUST create this verify_rc.sh script for C++
-          # It should untar, cmake, build, and run tests (ctest)
-          dev/release/verify_rc.sh "${version}" "${rc}"
+          # The verify_rc.sh script will untar and
+          # run cmake, build, tests (ctest) and install
+          VERIFY_SIGN=0 VERIFY_DOWNLOAD=0 dev/release/verify_rc.sh "${version}" "${rc}"
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
@@ -128,7 +125,7 @@ jobs:
       contents: write
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
 
       - uses: actions/download-artifact@v4
         with:

dev/release/README.md

@@ -37,13 +37,13 @@ $ dev/release/release_rc.sh ${VERSION} ${RC}
  You can use a draft shown by release_rc.sh for the email.)
 ```
 
-Here is an example to release RC1:
+Here is an example to release RC0 of version 0.1.0:
 
 ```console
-$ GH_TOKEN=${YOUR_GITHUB_TOKEN} dev/release/release_rc.sh 0.1.0 1
+$ GH_TOKEN=${YOUR_GITHUB_TOKEN} dev/release/release_rc.sh 0.1.0 0
 ```
 
-The arguments of `release_rc.sh` are the version and the RC number. If RC1 has a problem, we'll increment the RC number such as RC2, RC3 and so on.
+The arguments of `release_rc.sh` are the version and the RC number. If RC0 has a problem, we'll increment the RC number such as RC1, RC2 and so on.
 
 Requirements to run `release_rc.sh`:
 
@@ -71,9 +71,7 @@ $ svn ci KEYS
 
 ### Publish
 
-We need to do the following to publish a new release:
-
-    * Publish to apache.org
+We need to publish to apache.org to publish a new release.
 
 Run `dev/release/release.sh` to publish to apache.org:
 

dev/release/rat_exclude_files.txt

@@ -23,8 +23,6 @@ CHANGELOG.md
 build/**
 dist/**
 .git/**
-cmake_modules/**
-.cmake/**
 test/resources/**
 *.avro
 *.json

dev/release/verify_rc.sh

@@ -113,49 +113,6 @@ ensure_source_directory() {
   tar xf "${ARCHIVE_BASE_NAME}".tar.gz
 }
 
-check_compiler() {
-  echo "--- Verifying Build Environment ---"
-
-  # Check for minimum CMake version (e.g., 3.25)
-  MIN_CMAKE_VERSION="3.25"
-  CMAKE_VERSION=$(cmake --version | head -n1 | grep -oE '[0-9]+\.[0-9]+\.[0-9]+')
-  echo "Found CMake version: $CMAKE_VERSION"
-  if [ "$(printf '%s\n' "${MIN_CMAKE_VERSION}" "${CMAKE_VERSION}" | sort -V | head -n1)" != "${MIN_CMAKE_VERSION}" ]; then
-    echo "ERROR: CMake ${MIN_CMAKE_VERSION} or higher is required, but found ${CMAKE_VERSION}."
-    exit 1
-  fi
-
-  # Check for C++23 compliant compiler
-  local compiler_ok=0
-  if command -v g++ >/dev/null 2>&1; then
-    # Get major version: g++ (Debian 13.2.0-4) 13.2.0 -> 13
-    GCC_MAJOR_VERSION=$(g++ -dumpversion | cut -d. -f1)
-    echo "Found GCC version: $(g++ --version | head -n1)"
-    # GCC 13 is the first version with full C++23 support
-    if [ "${GCC_MAJOR_VERSION}" -ge 13 ]; then
-      echo "GCC version is sufficient for C++23."
-      compiler_ok=1
-    fi
-  fi
-
-  if [ "${compiler_ok}" -eq 0 ] && command -v clang++ >/dev/null 2>&1; then
-    CLANG_MAJOR_VERSION=$(clang++ --version | head -n1 | grep -oE '[0-9]+' | head -n1)
-    echo "Found Clang version: $(clang++ --version | head -n1)"
-    # Clang 16 is the first version with full C++23 support
-    if [ "${CLANG_MAJOR_VERSION}" -ge 16 ]; then
-      echo "Clang version is sufficient for C++23."
-      compiler_ok=1
-    fi
-  fi
-
-  if [ "${compiler_ok}" -eq 0 ]; then
-    echo "ERROR: No C++23 compliant compiler found (GCC 13+ or Clang 16+ required)."
-    exit 1
-  fi
-
-  echo "--- Environment check passed ---"
-}
-
 test_source_distribution() {
   echo "Building and testing Apache Iceberg C++..."
 
@@ -185,7 +142,6 @@ cd "${VERIFY_TMPDIR}"
 import_gpg_keys
 fetch_archive
 ensure_source_directory
-check_compiler
 pushd "${ARCHIVE_BASE_NAME}"
 test_source_distribution
 popd