review fixes

Author: NSAmelchev

docs/_docs/SQL/sql-tuning.adoc

@@ -52,10 +52,10 @@ Avoid having too many columns in the result set of a `SELECT` query. Due to limi
 
 == Lazy Loading
 
-Ignite always operates in lazy loading mode. Query results are not loaded entirely into memory — data is streamed to
-the client in pages as the result set is iterated. The page size determines how many rows are fetched per network round
-trip, allowing you to balance memory consumption and performance and eliminating the risk of prolonged GC pauses
-and `OutOfMemoryError` exceptions for large result sets.
+Ignite always operates in lazy loading mode. Query results are not loaded entirely into memory when possible. Data
+is streamed to the client in pages as the result set is iterated. The page size determines how many rows are fetched
+per network round trip, allowing you to balance memory consumption and performance and eliminating the risk of
+prolonged GC pauses and `OutOfMemoryError` exceptions for large result sets.
 
 == Querying Colocated Data
 

docs/_docs/binary-client-protocol/sql-and-scan-queries.adoc

@@ -267,6 +267,7 @@ UPDATE = 2
 |bool|    Replicated only - Whether query contains only replicated tables or not.
 |bool|    Enforce join order.
 |bool|    Collocated - Whether your data is co-located or not.
+|bool|    [Deprecated] Lazy query execution. This flag is not used anymore on server side.
 |long|    Timeout (milliseconds).
 |bool|    Include field names.
 |===

docs/_docs/perf-and-troubleshooting/sql-tuning.adoc

@@ -78,10 +78,10 @@ with 100+ columns may perform worse than expected.
 
 == Lazy Loading
 
-Ignite always operates in lazy loading mode. Query results are not loaded entirely into memory — data is streamed to
-the client in pages as the result set is iterated. The page size determines how many rows are fetched per network round
-trip, allowing you to balance memory consumption and performance and eliminating the risk of prolonged GC pauses
-and `OutOfMemoryError` exceptions for large result sets.
+Ignite always operates in lazy loading mode. Query results are not loaded entirely into memory when possible. Data
+is streamed to the client in pages as the result set is iterated. The page size determines how many rows are fetched
+per network round trip, allowing you to balance memory consumption and performance and eliminating the risk of
+prolonged GC pauses and `OutOfMemoryError` exceptions for large result sets.
 
 == Querying Colocated Data
 

modules/clients/src/test/java/org/apache/ignite/jdbc/thin/JdbcThinConnectionSelfTest.java

@@ -453,8 +453,13 @@ public void testSqlHintsSemicolon() throws Exception {
      * @throws Exception If failed.
      */
     private void assertHints(
-        Connection conn, boolean distributedJoins, boolean enforceJoinOrder, boolean collocated,
-        boolean replicatedOnly, boolean skipReducerOnUpdate, boolean partitionAwarenessEnabled
+        Connection conn,
+        boolean distributedJoins,
+        boolean enforceJoinOrder,
+        boolean collocated,
+        boolean replicatedOnly,
+        boolean skipReducerOnUpdate,
+        boolean partitionAwarenessEnabled
     ) throws Exception {
         for (JdbcThinTcpIo io: ios(conn)) {
             assertEquals(distributedJoins, io.connectionProperties().isDistributedJoins());

modules/core/src/main/java/org/apache/ignite/internal/processors/platform/cache/PlatformCache.java

@@ -1491,7 +1491,6 @@ private Query readFieldsQuery(BinaryReaderEx reader) {
 
         boolean distrJoins = reader.readBoolean();
         boolean enforceJoinOrder = reader.readBoolean();
-        reader.readBoolean(); // Lazy flag.
         int timeout = reader.readInt();
         boolean replicated = reader.readBoolean();
         boolean collocated = reader.readBoolean();

modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/H2QueryInfo.java

@@ -64,9 +64,6 @@ public class H2QueryInfo implements TrackableQuery {
     /** Join batch enabled (distributed join). */
     private final boolean distributedJoin;
 
-    /** Lazy mode. */
-    private final boolean lazy;
-
     /** Prepared statement. */
     private final Prepared stmt;
 
@@ -108,7 +105,6 @@ public H2QueryInfo(QueryType type, PreparedStatement stmt, String sql, UUID node
 
             enforceJoinOrder = s.isForceJoinOrder();
             distributedJoin = s.isJoinBatchEnabled();
-            lazy = s.isLazyQueryExecution();
             this.stmt = GridSqlQueryParser.prepared(stmt);
         }
         catch (SQLException e) {

modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/RegisteredQueryCursor.java

@@ -68,8 +68,13 @@ public class RegisteredQueryCursor<T> extends QueryCursorImpl<T> {
      * @param qryId Registered running query id.
      * @param tracing Tracing processor.
      */
-    public RegisteredQueryCursor(Iterable<T> iterExec, GridQueryCancel cancel, RunningQueryManager runningQryMgr,
-        long qryId, Tracing tracing) {
+    public RegisteredQueryCursor(
+        Iterable<T> iterExec,
+        GridQueryCancel cancel,
+        RunningQueryManager runningQryMgr,
+        long qryId,
+        Tracing tracing
+    ) {
         super(iterExec, cancel, true);
 
         assert runningQryMgr != null;

modules/indexing/src/test/java/org/apache/ignite/client/FunctionalQueryTest.java

@@ -125,8 +125,13 @@ public void testQueries() throws Exception {
      * @param expSize The size of the expected results.
      * @param exp Expected results.
      */
-    private void checkSqlFieldsQuery(ClientCache<Integer, Person> cache, int minId, int pageSize, int expSize,
-        Map<Integer, Person> exp) {
+    private void checkSqlFieldsQuery(
+        ClientCache<Integer, Person> cache,
+        int minId,
+        int pageSize,
+        int expSize,
+        Map<Integer, Person> exp
+    ) {
         SqlFieldsQuery qry = new SqlFieldsQuery("select id, name from Person where id >= ?")
             .setArgs(minId)
             .setPageSize(pageSize);

modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/LongRunningQueryTest.java

@@ -194,7 +194,7 @@ private static CacheConfiguration cacheConfig(String name, Class<?>... idxTypes)
      *
      */
     @Test
-    public void testLongDistributedLazy() {
+    public void testLongDistributed() {
         local = false;
 
         checkLongRunning();
@@ -205,7 +205,7 @@ public void testLongDistributedLazy() {
      *
      */
     @Test
-    public void testLongDistributedLazyWithMergeTable() {
+    public void testLongDistributedWithMergeTable() {
         local = false;
 
         withMergeTable = true;
@@ -222,7 +222,7 @@ public void testLongDistributedLazyWithMergeTable() {
      *
      */
     @Test
-    public void testLongLocalLazy() {
+    public void testLongLocal() {
         local = true;
 
         checkLongRunning();
@@ -330,21 +330,21 @@ public void testLongRunningDeleteWithSubqueryLocal() {
      * the execution of distributed queries.
      */
     @Test
-    public void testDistributedLazyWithExternalWait() {
+    public void testDistributedWithExternalWait() {
         local = false;
 
-        checkLazyWithExternalWait();
+        checkWithExternalWait();
     }
 
     /**
      * Test checks that no long-running queries warnings are printed in case of external waits during
      * the execution of local queries.
      */
     @Test
-    public void testlocalLazyWithExternalWait() {
+    public void testLocalWithExternalWait() {
         local = true;
 
-        checkLazyWithExternalWait();
+        checkWithExternalWait();
     }
 
     /**
@@ -652,7 +652,7 @@ private FieldsQueryCursor<List<?>> sql(String cacheName, String sql, Object... a
     }
 
     /** */
-    public void checkLazyWithExternalWait() {
+    public void checkWithExternalWait() {
         pageSize = 1;
 
         LogListener lsnr = LogListener

modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/oom/AbstractQueryOOMTest.java

@@ -271,7 +271,7 @@ public void testHeavySortByNotIndexNotLazy() throws Exception {
      * @throws Exception On error.
      */
     @Test
-    public void testHeavyGroupByPkLazy() throws Exception {
+    public void testHeavyGroupByPk() throws Exception {
         checkQuery("SELECT id, sum(val) from test GROUP BY id", KEY_CNT, true);
     }