-
Notifications
You must be signed in to change notification settings - Fork 50
Allow plugin support for custom compression/decompression (e.g. zstd) #997
Description
Feature request: Plug-in support for custom compression (e.g., zstd) in Pekko HTTP coding subsystem
Context
Currently, Pekko HTTP provides built-in support for gzip (and deflate) compression via the Coder abstraction in org.apache.pekko.http.scaladsl.coding. This is used via encodeResponse, decodeRequest, and related directives, and the negotiation machinery is well-established. There is frequent interest (e.g., for modern formats like zstd) in supporting custom content encoding algorithms. Users may want to plug in their own encoders/decoders without modifying Pekko HTTP core code.
There is #860 which is about adding built-in support for zstd but it might be worth considering allowing the addition of custom compression/decompression so users can add support themselves.
Analysis
After reviewing the codebase (scaladsl/coding), here's what enables and what currently blocks custom compressions:
What works:
Coderis a marker trait (trait Coder extends Encoder with Decoder). Users can implement it today to support new encodings, e.g., zstd.HttpEncoding.custom(...)allows defining new encoding tokens, such aszstd.- Directives (
encodeResponseWith,decodeRequestWith) accept arbitraryEncoder/Decoders, so user-provided implementations can already be injected explicitly per-route.
Current barriers:
- Compressor and StreamDecoder are Internal/Deprecated:
Compressor(needed for encoding) andStreamDecoder(for decoding) are@InternalApiand@deprecated. ImplementingEncoder/Decoderneeds usage of these, but they're not public API and may change or disappear, so user-providers can't rely on them.
- Java API is closed:
- The Java-side equivalent (
org.apache.pekko.http.javadsl.coding.Coder) is a closedenum—Java users cannot add custom encoders at all.
- The Java-side equivalent (
- Default coders are fixed:
Coders.DefaultCodersis always[Gzip, Deflate, NoCoding]. There is no mechanism for registering a custom coder with the negotiation machinery globally. So, while you can use your custom coder per-route with theWithdirectives, it won't be automatically used with default directives.
Example: How it could work (after stabilising APIs)
object ZstdCoder extends Coder with StreamDecoder {
val encoding: HttpEncoding = HttpEncoding.custom("zstd")
def messageFilter = Encoder.DefaultFilter
private[this] def newCompressor = new ZstdCompressor() // if Compressor is public
def newDecompressorStage(maxBytesPerChunk: Int) = () => new ZstdDecompressorStage(maxBytesPerChunk)
}
// Usage:
encodeResponseWith(ZstdCoder, Coders.Gzip, Coders.Deflate, Coders.NoCoding) { ... }
decodeRequestWith(ZstdCoder, Coders.Gzip, Coders.Deflate) { ... }Proposed Enhancements
- Promote Compressor and StreamDecoder to Public API:
- Remove
@InternalApiand@deprecatedfrom these types - Alternatively, provide a new public API for plugging in custom encoder/decoder flows
- Remove
- Open up Java API for Custom Coders:
- Replace or supplement the hardcoded
Coderenum with an interface/factory-based mechanism in the Java DSL
- Replace or supplement the hardcoded
- Make DefaultCoders Configurable or Injectable:
- Allow applications to register additional coders (e.g., via ActorSystem config or a registration method) for use by the default directives/negotiator
- (Optional) Add zstd as a built-in or contrib module:
- To showcase extensibility and provide instant value
- (Docs) Add a guide for implementing and registering custom coders
Impact
- This would unlock modern and/or domain-specific compression for Pekko HTTP users
- Immediate benefit for projects that need zstd or other algorithms (Brotli, LZ4, etc.)
- Makes Pekko HTTP encoding/decoding as extensible as its routing layers
If maintainers agree, I'm happy to help with API stabilisation PRs or further design discussion!
Origin: https://github.com/apache/pekko-http (discussion/analysis by pjfanning)