From 31908df0da336c7fb65389bcb01a1f24186df7b0 Mon Sep 17 00:00:00 2001 From: Nik Polevara Date: Sun, 1 Feb 2026 14:33:56 +0200 Subject: [PATCH] remove old flags implementation --- lib/mix/tasks/esp32_flash.ex | 26 +++++++------------------- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/lib/mix/tasks/esp32_flash.ex b/lib/mix/tasks/esp32_flash.ex index beb2b15..557e0a7 100644 --- a/lib/mix/tasks/esp32_flash.ex +++ b/lib/mix/tasks/esp32_flash.ex @@ -99,16 +99,16 @@ defmodule Mix.Tasks.Atomvm.Esp32.Flash do "--baud", baud, "--before", - "default_reset", + "default-reset", "--after", - "hard_reset", - "write_flash", + "hard-reset", + "write-flash", "-u", - "--flash_mode", + "--flash-mode", "keep", - "--flash_freq", + "--flash-freq", "keep", - "--flash_size", + "--flash-size", "detect", "0x#{Integer.to_string(flash_offset, 16)}", "#{Project.config()[:app]}.avm" @@ -121,18 +121,6 @@ defmodule Mix.Tasks.Atomvm.Esp32.Flash do IO.puts("Flashing using Pythonx installed esptool..") ExAtomVM.EsptoolHelper.setup() - # avoid deprecation warnings, as we know we are esptool version 5+, when using Pythonx. - tool_args = - Enum.map(tool_args, fn - "--flash_mode" -> "--flash-mode" - "--flash_freq" -> "--flash-freq" - "--flash_size" -> "--flash-size" - "default_reset" -> "default-reset" - "hard_reset" -> "hard-reset" - "write_flash" -> "write-flash" - arg -> arg - end) - case ExAtomVM.EsptoolHelper.flash_pythonx(tool_args) do true -> exit({:shutdown, 0}) false -> exit({:shutdown, 1}) @@ -153,7 +141,7 @@ defmodule Mix.Tasks.Atomvm.Esp32.Flash do end defp get_esptool_path(<<"">>) do - "esptool.py" + "esptool" end defp get_esptool_path(idf_path) do