fix(lints): Fixed a series of lint warnings preventing release, and removed quite a bit of dead code in the process.

Author: bashandbone

src/commands.rs

@@ -51,7 +51,7 @@ See the [README.md](../README.md) for full usage and configuration details.
 "#]
 
 use crate::shells::Shell;
-use clap::{Parser, Subcommand, arg, command};
+use clap::{Parser, Subcommand};
 
 use crate::long_abouts::COMPLETE_ME;
 use crate::options::{

src/config.rs

@@ -57,6 +57,7 @@ fn shallow_filter(shallow: &bool) -> bool {
 }
 
 // Just a type wrapper around str to make it clear what we're working with
+/// A type alias for submodule names used throughout the configuration.
 pub type SubmoduleName = String;
 
 /// Git options for a submodule
@@ -76,6 +77,7 @@ pub struct SubmoduleGitOptions {
     pub update: Option<SerializableUpdate>,
 }
 
+#[allow(dead_code)]
 impl SubmoduleGitOptions {
     /// Create a new instance with defaults
     pub fn new(
@@ -104,6 +106,7 @@ impl SubmoduleGitOptions {
 }
 
 /// Convert git submodule options to git2-compatible options
+#[allow(dead_code)]
 pub struct Git2SubmoduleOptions {
     ignore: git2::SubmoduleIgnore,
     update: git2::SubmoduleUpdate,
@@ -112,7 +115,9 @@ pub struct Git2SubmoduleOptions {
 }
 
 /// Implementation for converting git2 submodule options
+#[allow(dead_code)]
 impl Git2SubmoduleOptions {
+    /// Create a new `Git2SubmoduleOptions` from individual git2 option values.
     pub fn new(
         ignore: git2::SubmoduleIgnore,
         update: git2::SubmoduleUpdate,
@@ -171,6 +176,7 @@ impl Iterator for SubmoduleDefaults {
     }
 }
 
+#[allow(dead_code)]
 impl SubmoduleDefaults {
     /// Returns a vector of SubmoduleDefaults with the current values (for comparison)
     pub fn get_values(&self) -> Vec<SubmoduleDefaults> {
@@ -223,9 +229,11 @@ pub struct SubmoduleAddOptions {
     /// Whether to create a shallow clone
     pub shallow: bool,
     /// Whether to skip initialization after adding
+    #[allow(dead_code)]
     pub no_init: bool,
 }
 
+#[allow(dead_code)]
 impl SubmoduleAddOptions {
     /// Create an add options from a SubmoduleEntry
     pub fn into_submodule_entry(self) -> SubmoduleEntry {
@@ -282,6 +290,7 @@ pub struct SubmoduleUpdateOptions {
     pub force: bool,
 }
 
+#[allow(dead_code)]
 impl SubmoduleUpdateOptions {
     /// Create a new instance with defaults
     pub fn new(strategy: SerializableUpdate, recursive: bool, force: bool) -> Self {
@@ -349,6 +358,7 @@ pub struct OtherSubmoduleSettings {
     pub no_init: bool,
 }
 
+#[allow(dead_code)]
 impl OtherSubmoduleSettings {
     /// Create a new instance with default values
     fn default() -> Self {
@@ -452,6 +462,7 @@ pub struct SubmoduleEntry {
     pub sparse_paths: Option<Vec<String>>,
 }
 
+#[allow(dead_code)]
 impl SubmoduleEntry {
     /// Create a new submodule entry with defaults
     pub fn new(
@@ -597,6 +608,7 @@ impl SubmoduleEntry {
         url.rsplit(&['/', ':'][..]).next().unwrap_or("").to_string()
     }
 
+    /// Returns the git-specific options for this submodule entry.
     pub fn git_options(&self) -> SubmoduleGitOptions {
         SubmoduleGitOptions {
             ignore: self.ignore.clone(),
@@ -606,6 +618,7 @@ impl SubmoduleEntry {
         }
     }
 
+    /// Returns the non-git settings for this submodule entry (path, url, active state, etc.).
     pub fn settings(&self) -> OtherSubmoduleSettings {
         OtherSubmoduleSettings {
             name: None, // We don't have a name in this struct, so we leave it as None
@@ -703,6 +716,7 @@ impl Serialize for SubmoduleEntries {
     }
 }
 
+#[allow(dead_code)]
 impl SubmoduleEntries {
     /// Create a new empty SubmoduleEntries
     pub fn new(
@@ -715,6 +729,7 @@ impl SubmoduleEntries {
         }
     }
 
+    /// Create a new empty `SubmoduleEntries` with default (empty) collections.
     pub fn default() -> Self {
         Self {
             submodules: Some(HashMap::new()),
@@ -749,6 +764,7 @@ impl SubmoduleEntries {
         self.clone()
     }
 
+    /// Returns a list of all submodule names, or `None` if no submodules are configured.
     pub fn submodule_names(&self) -> Option<Vec<String>> {
         self.submodules
             .as_ref()
@@ -823,6 +839,7 @@ impl SubmoduleEntries {
         self.submodules.as_ref()?.get(name)
     }
 
+    /// Returns `true` if a submodule with the given name exists.
     pub fn contains_key(&self, name: &str) -> bool {
         self.submodules
             .as_ref()
@@ -910,6 +927,7 @@ pub struct Config {
     pub submodules: SubmoduleEntries,
 }
 
+#[allow(dead_code)]
 impl Config {
     /// Create a new configuration with the given defaults and submodules
     pub fn new(defaults: SubmoduleDefaults, submodules: SubmoduleEntries) -> Self {

src/git_manager.rs

@@ -834,11 +834,13 @@ impl GitManager {
     }
 
     /// Get mutable reference to the underlying config
+    #[allow(dead_code)]
     pub const fn config_mut(&mut self) -> &mut Config {
         &mut self.config
     }
 
     /// Get a clone of the underlying config
+    #[allow(dead_code)]
     pub fn config_clone(&self) -> Config {
         self.config.clone()
     }
@@ -957,7 +959,7 @@ impl GitManager {
         };
 
         // Build the current submodule map sorted by name for deterministic append order
-        let mut current_entries: std::collections::BTreeMap<String, &SubmoduleEntry> =
+        let current_entries: std::collections::BTreeMap<String, &SubmoduleEntry> =
             self.config.get_submodules().map(|(n, e)| (n.clone(), e)).collect();
 
         // Track which names appeared in the existing file (so we know what to append)

src/git_ops/git2_ops.rs

@@ -124,6 +124,7 @@ impl Git2Operations {
         Ok(shallow_file.exists())
     }
     /// Convert git2 status flags to our status flags
+    #[allow(dead_code)]
     fn convert_git2_status_to_flags(&self, status: git2::SubmoduleStatus) -> SubmoduleStatusFlags {
         let mut flags = SubmoduleStatusFlags::empty();
         if status.contains(git2::SubmoduleStatus::IN_HEAD) {
@@ -171,6 +172,7 @@ impl Git2Operations {
         flags
     }
     /// Get git config at specified level
+    #[allow(dead_code)]
     fn get_config_at_level(&self, level: ConfigLevel) -> Result<git2::Config> {
         match level {
             ConfigLevel::Local => self.repo.config(),
@@ -270,7 +272,7 @@ impl GitOperations for Git2Operations {
             if let (Some(name), Some(value)) = (entry.name(), entry.value()) {
                 entries.insert(name.to_string(), value.to_string());
             }
-        });
+        })?;
         Ok(GitConfig { entries })
     }
     fn write_git_config(&self, config: &GitConfig, level: ConfigLevel) -> Result<()> {
@@ -716,6 +718,7 @@ impl GitOperations for Git2Operations {
 }
 impl Git2Operations {
     /// Get sparse checkout information for a submodule
+    #[allow(dead_code)]
     fn get_sparse_checkout_info(&self, path: &str) -> Result<(bool, Vec<String>)> {
         let submodule = self
             .repo

src/git_ops/gix_ops.rs

@@ -5,10 +5,9 @@
 use anyhow::{Context, Result};
 use gix::bstr::ByteSlice;
 use std::collections::HashMap;
-use std::path::{Path, PathBuf};
+use std::path::Path;
 
-use crate::git_ops::simple_gix::{clone_repo, fetch_repo};
-use crate::utilities::repo_from_path;
+use crate::git_ops::simple_gix::fetch_repo;
 
 /// Parse a gix config file from raw bytes
 fn gix_file_from_bytes(bytes: Vec<u8>) -> Result<gix::config::File<'static>> {
@@ -23,7 +22,7 @@ fn gix_file_from_bytes(bytes: Vec<u8>) -> Result<gix::config::File<'static>> {
 
 use super::{DetailedSubmoduleStatus, GitConfig, GitOperations, SubmoduleStatusFlags};
 use crate::config::{
-    SubmoduleAddOptions, SubmoduleEntries, SubmoduleEntry, SubmoduleUpdateOptions,
+    SubmoduleAddOptions, SubmoduleEntries, SubmoduleUpdateOptions,
 };
 use crate::options::{ConfigLevel, GitmodulesConvert};
 use crate::utilities;
@@ -100,6 +99,7 @@ impl GixOperations {
     }
 
     /// Convert gix submodule status to our status flags
+    #[allow(dead_code)]
     fn convert_gix_status_to_flags(&self, status: &gix::submodule::Status) -> SubmoduleStatusFlags {
         let mut flags = SubmoduleStatusFlags::empty();
         // Map gix status to our flags

src/git_ops/mod.rs

@@ -10,7 +10,9 @@ providing seamless integration for submodule management and configuration tasks.
 
 We prefer Gix, but it's still unstable and several core features are missing, so we use git2 as a fallback for those features and for stability.
 "]
+/// git2-based git operations implementation
 pub mod git2_ops;
+/// gitoxide (gix)-based git operations implementation
 pub mod gix_ops;
 pub mod simple_gix;
 pub use git2_ops::Git2Operations;
@@ -28,6 +30,7 @@ use crate::options::{
 };
 
 /// Represents git configuration state
+#[allow(dead_code)]
 #[derive(Debug, Clone, PartialEq, Eq)]
 pub struct GitConfig {
     /// Configuration entries as key-value pairs
@@ -70,6 +73,7 @@ bitflags! {
 }
 
 /// Comprehensive submodule status information
+#[allow(dead_code)]
 #[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Hash)]
 pub struct DetailedSubmoduleStatus {
     /// Path of the submodule
@@ -114,10 +118,13 @@ pub trait GitOperations {
     /// Write .gitmodules configuration
     fn write_gitmodules(&mut self, config: &SubmoduleEntries) -> Result<()>;
     /// Read git configuration at specified level
+    #[allow(dead_code)]
     fn read_git_config(&self, level: ConfigLevel) -> Result<GitConfig>;
     /// Write git configuration at specified level
+    #[allow(dead_code)]
     fn write_git_config(&self, config: &GitConfig, level: ConfigLevel) -> Result<()>;
     /// Set a single configuration value
+    #[allow(dead_code)]
     fn set_config_value(&self, key: &str, value: &str, level: ConfigLevel) -> Result<()>;
 
     // Submodule operations
@@ -132,12 +139,14 @@ pub trait GitOperations {
     /// Deinitialize a submodule
     fn deinit_submodule(&mut self, path: &str, force: bool) -> Result<()>;
     /// Get detailed status of a submodule
+    #[allow(dead_code)]
     fn get_submodule_status(&self, path: &str) -> Result<DetailedSubmoduleStatus>;
     /// List all submodules
     fn list_submodules(&self) -> Result<Vec<String>>;
 
     // Repository operations
     /// Fetch a submodule
+    #[allow(dead_code)]
     fn fetch_submodule(&self, path: &str) -> Result<()>;
     /// Reset a submodule
     fn reset_submodule(&self, path: &str, hard: bool) -> Result<()>;