fix: practice mode hp stacking glitch (#68)

* refactor + fix hp stacking

* docs: update docs.md

* clean code

Author: weebao

.env.example

@@ -71,7 +71,7 @@ STARTING_MP=100
 MANA_RECHARGE=50
 
 # Unranked Problem Distribution #
-UNRANKED_PROBS="0.8, 0.19, 0.01"
+UNRANKED_PROBS="0.4, 0.3, 0.3"
 
 # HP Deduction Settings
 HP_DEDUCTION_BASE=4
@@ -81,15 +81,15 @@ HP_MULTIPLIER="1.0, 1.5, 2.0"
 RATING_K_FACTOR=32
 RANK_THRESHOLDS="0, 100, 200, 500, 1200, 1600, 2400"
 RANK_NAMES="O(n!), O(2ⁿ), O(n²), O(nlogn), O(n), O(logn), O(1)"
-RANK_PROBLEM_DISTRIBUTION="3-0-0, 2-1-0, 1-2-0, 0-3-0, 0-2-1, 0-1-2, 0-0-3"
+RANK_PROBLEM_DISTRIBUTION="3-0-0, 2-1-0, 1-2-0, 0-3-0, 0-2-1, 0-1-2, 0-0-3" # Only 3 problems per match
 
 ### Custom Room Settings ###
 ROOM_CODE_LENGTH=6
 ROOM_PROBLEM_COUNT=3
 ROOM_STARTING_HP=100
 ROOM_HP_MULTIPLIER="1.0, 1.5, 2.0"
 ROOM_DISTRIBUTION="auto"
-ROOM_PROBLEM_DISTRIBUTION="0.8, 0.19, 0.01"
+ROOM_PROBLEM_DISTRIBUTION="0.4, 0.3, 0.3"
 ROOM_UPDATE_THROTTLE=0
 ROOM_BASE_HP_DEDUCTION=4
 ROOM_STARTING_SP=100
@@ -112,4 +112,4 @@ PRACTICE_THINKING_TIME=30
 BOT_THINKING_MULTIPLIER="1.0, 2.0, 3.0"
 BOT_ACTION_INTERVAL_MULTIPLIER="1.2, 1.0, 0.7"
 BOT_DAMAGE_MULTIPLIER="0.8, 1.0, 1.2"
-BOT_ABILITY_USE_CHANCE="0.5, 0.4, 0.3"
+BOT_ABILITY_USE_CHANCE="0.5, 0.4, 0.3"

DOCS.md

@@ -3,7 +3,7 @@
 ### General Notes
 ⚠️ FastAPI automatically generates Swagger-style documentation at /docs for all the HTTP endpoints (no WebSockets).
 
-⚠️ The default API endpoint starts with `/api` (after your host address) 
+⚠️ The default API endpoint starts with `/api` (after your host address)
 
 ⚠️ The URL suffix matters! When connecting to HTTP endpoints you'll use `http://` but whe connecting to WS endpoints you'll use `ws://`. The secure version of these protocols are `https://` and `wss://`, respectively.
 
@@ -38,7 +38,7 @@ ALTERNATIVELY: Send a POST request to `/api/users/guest` to get `access_token` a
 1. To start queueing for a match, join the WebSocket endpoint `/game/queue` (unranked) or `/game/ranked-queue`  (ranked).
    - These two are pretty much the same, except ranked games are matched based on rating proximity and give rating changes.
    - The problems distribution in unranked matches are based on appearance chances, but in ranked the distribution of problemsare predetermined (check .env settings)
-2. Once a match is found, a WebSocket JSON object of `type: "match_found"` will be sent to you. Inside `data` includes information like your `"match_id"` and opponent details. 
+2. Once a match is found, a WebSocket JSON object of `type: "match_found"` will be sent to you. Inside `data` includes information like your `"match_id"` and opponent details.
 3. Use the mentioned `"match_id"` to connect to the WebSocket of the game e.g. `/game/play/{match_id}`
 4. While inside the game websocket, here are the messages you'll receive:
    - `type: "game_state"`: sent on join/query; contains information about the current state of the game (you and your opponent)
@@ -52,7 +52,7 @@ ALTERNATIVELY: Send a POST request to `/api/users/guest` to get `access_token` a
      - `code: string`: your code string (includes boilerplate)
      - `lang: 'python' | 'java' | 'cpp'`: your code's language
    - `type: "forfeit"`: used to forfeit the match
-   - `type: "query"`: used to fetch current match data. 
+   - `type: "query"`: used to fetch current match data.
    - `type: "ability"`: used to signal a buy/use of abilities. Inside your `"data"` property:
      - `action: string`: either `buy` or `use`
      - `ability_id: string`: the ID string of the ability
@@ -87,6 +87,12 @@ ALTERNATIVELY: Send a POST request to `/api/users/guest` to get `access_token` a
    - `type: "chat"`: used to send a message to your opponent in the  room. Inside your `"data"` property:
      - `message: string`: the message you want to send
 
+#### 9. Practice Mode
+1. Connect to practice mode WebSocket at `/practice`.
+2. You will receive the same JSON objects as in the [Game Mode](#4-matchmaking-and-game-flow)
+3. Additional JSON objects you can send:
+   - `type: "change_bot_difficulty"`: change the difficulty of the bot ("easy", "medium", "hard") in `"difficulty"` field inside `"data"`.
+
 ⚠️ Both players will still remain in the room while in-match.
-⚠️ Disconnection from the room WebSocket counts as leaving the room. 
-> Hence it is advised the frontend keeps the room WebSocket alive during game as well and have the players return to the room screen after finishing the match e.g. `"match_end"` event
+⚠️ Disconnection from the room WebSocket counts as leaving the room.
+> Hence it is advised the frontend keeps the room WebSocket alive during game as well and have the players return to the room screen after finishing the match e.g. `"match_end"` event

app/api/endpoints/game/websockets.py

@@ -206,7 +206,6 @@ async def game_websocket(
             {"type": "game_state", "data": game_view.model_dump()}
         )
 
-        # Send the current problem if the game is in progress
         if (
             game_state.status == GameStatus.IN_PROGRESS
             and player.current_problem_index < len(game_state.problems)
@@ -216,7 +215,6 @@ async def game_websocket(
             )
             await websocket.send_json({"type": "problem", "data": current_problem})
 
-        # Start the game if both players are connected and the game is waiting
         opponent = game_state.get_opponent_state(current_user.id)
         if opponent and opponent.ws and game_state.status == GameStatus.WAITING:
             game_state.status = GameStatus.IN_PROGRESS
@@ -231,7 +229,6 @@ async def game_websocket(
             try:
                 data = await asyncio.wait_for(websocket.receive_json(), timeout=1.0)
 
-                # No longer accept messages if the game is finished
                 if game_state.status == GameStatus.FINISHED:
                     break
 
@@ -258,6 +255,9 @@ async def game_websocket(
                         )
 
                 elif data["type"] == "query":
+                    game_view = game_manager.create_game_view(
+                        game_state, current_user.id
+                    )
                     await websocket.send_json(
                         {"type": "game_state", "data": game_view.model_dump()}
                     )
@@ -269,7 +269,6 @@ async def game_websocket(
                     submission_cooldown = (
                         settings.SUBMISSION_COOLDOWN if not settings.TESTING else 2
                     )
-                    # Check if the player is submitting too fast
                     if (
                         player.last_submission is not None
                         and current_time - player.last_submission < submission_cooldown
@@ -341,7 +340,6 @@ async def game_websocket(
                             )
                         )
 
-                        # Send the next problem if the current one was solved
                         if (
                             submission_result["problem_solved"]
                             and problem_index < len(game_state.problems) - 1
@@ -356,7 +354,6 @@ async def game_websocket(
                         if await game_manager.check_game_end(game_id):
                             await game_manager.handle_game_end(game_state, db)
                     else:
-                        # Submission failed, send the result to the player
                         await player.send_event(
                             GameEvent(type="submission_result", data=result)
                         )