fix: honor create dry-run with explicit types (#326)

Signed-off-by: Davanum Srinivas <davanum@gmail.com>

Author: dims

pkg/cmd/gpucreate/gpucreate.go

@@ -179,12 +179,12 @@ func NewCmdGPUCreate(t *terminal.Terminal, gpuCreateStore GPUCreateStore) *cobra
 				return breverrors.WrapAndTrace(err)
 			}
 
+			if dryRun {
+				return runDryRun(t, gpuCreateStore, types, &filters)
+			}
+
 			// If no types provided, use search filters (or defaults) to find suitable GPUs
 			if len(types) == 0 {
-				if dryRun {
-					return runDryRun(t, gpuCreateStore, &filters)
-				}
-
 				types, err = getFilteredInstanceTypes(gpuCreateStore, &filters)
 				if err != nil {
 					return breverrors.WrapAndTrace(err)
@@ -369,7 +369,12 @@ func getFilteredInstanceTypes(s GPUCreateStore, filters *searchFilterFlags) ([]I
 }
 
 // runDryRun shows the instance types that would be used without creating anything
-func runDryRun(t *terminal.Terminal, s GPUCreateStore, filters *searchFilterFlags) error {
+func runDryRun(t *terminal.Terminal, s GPUCreateStore, specs []InstanceSpec, filters *searchFilterFlags) error {
+	if len(specs) > 0 {
+		t.Print(formatInstanceSpecs(specs))
+		return nil
+	}
+
 	filtered, _, err := searchInstances(s, filters)
 	if err != nil {
 		return breverrors.WrapAndTrace(err)

pkg/cmd/gpucreate/gpucreate_test.go

@@ -7,6 +7,7 @@ import (
 	"github.com/brevdev/brev-cli/pkg/cmd/gpusearch"
 	"github.com/brevdev/brev-cli/pkg/entity"
 	"github.com/brevdev/brev-cli/pkg/store"
+	"github.com/brevdev/brev-cli/pkg/terminal"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -300,6 +301,18 @@ func TestMockGPUCreateStoreTypeSpecificError(t *testing.T) {
 	assert.NotNil(t, ws)
 }
 
+func TestCreateDryRunWithExplicitTypesDoesNotProvision(t *testing.T) {
+	mock := NewMockGPUCreateStore()
+	term := terminal.New()
+
+	cmd := NewCmdGPUCreate(term, mock)
+	cmd.SetArgs([]string{"dry-run-test", "--type", "g5.xlarge", "--dry-run"})
+
+	err := cmd.Execute()
+	assert.NoError(t, err)
+	assert.Empty(t, mock.CreatedWorkspaces)
+}
+
 func TestGetFilteredInstanceTypesDefaults(t *testing.T) {
 	mock := NewMockGPUCreateStore()