Skip to content

Commit f815d21

Browse files
committed
review feedback
1 parent 3f4278c commit f815d21

3 files changed

Lines changed: 2 additions & 38 deletions

File tree

bin/install-latest-linux.sh

Lines changed: 0 additions & 36 deletions
This file was deleted.

bin/install-latest.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ API_RESPONSE="$(curl -sf ${GITHUB_TOKEN:+-H "Authorization: token ${GITHUB_TOKEN
2020
}
2121

2222
# Extract the download URL for this platform
23-
DOWNLOAD_URL="$(echo "${API_RESPONSE}" | grep "browser_download_url.*${OS}.*${ARCH}" | cut -d '"' -f 4)"
23+
DOWNLOAD_URL="$(echo "${API_RESPONSE}" | grep "browser_download_url.*${OS}.*${ARCH}" | cut -d '"' -f 4 || true)"
2424
if [ -z "${DOWNLOAD_URL}" ]; then
2525
echo "Error: Could not find release for ${OS} ${ARCH}" >&2
2626
echo "GitHub API response (truncated): ${API_RESPONSE:0:200}" >&2

scripts/install-agent-skill.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ if echo "$VERSION_RESPONSE" | grep -q "API rate limit exceeded"; then
122122
echo -e " ${YELLOW}If you are using a VPN, try turning it off and running this script again.${NC}"
123123
echo -e " ${YELLOW}See: https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting${NC}"
124124
else
125-
COMMIT_SHA=$(echo "$VERSION_RESPONSE" | grep '"sha"' | head -1 | sed 's/.*"sha": *"\([^"]*\)".*/\1/')
125+
COMMIT_SHA=$(echo "$VERSION_RESPONSE" | grep '"sha"' | head -1 | sed 's/.*"sha": *"\([^"]*\)".*/\1/' || true)
126126
if [[ -n "$COMMIT_SHA" ]]; then
127127
for dir in "${INSTALL_DIRS[@]}"; do
128128
printf 'branch=%s\ncommit=%s\n' "$BRANCH" "$COMMIT_SHA" > "$dir/.version"

0 commit comments

Comments
 (0)