Reintroduce CEL spec version in filename

Dropped in #374, but needed to pick up updates to the file trivially
with `make`.

Also, bump to 0.25.1 now that it's been released.

Author: stefanvanburen

Makefile

@@ -18,8 +18,9 @@ ADD_LICENSE_HEADER := $(BIN)/license-header \
 # This version should be kept in sync with the version in buf.yaml
 PROTOVALIDATE_VERSION ?= v1.0.0
 # Version of the cel-spec that this implementation is conformant with
-CEL_SPEC_VERSION ?= v0.25.0
-TESTDATA_FILE := test/testdata/string_ext.textproto
+# This should be kept in sync with the version in test/test_format.py
+CEL_SPEC_VERSION ?= v0.25.1
+TESTDATA_FILE := test/testdata/string_ext_$(CEL_SPEC_VERSION).textproto
 
 .PHONY: help
 help: ## Describe useful make targets

test/test_format.py

@@ -26,6 +26,10 @@
 from protovalidate.internal import extra_func
 from protovalidate.internal.cel_field_presence import InterpretedRunner
 
+# Version of the cel-spec that this implementation is conformant with.
+# This should be kept in sync with the version in ../Makefile.
+CEL_SPEC_VERSION = "v0.25.1"
+
 skipped_tests = [
     # cel-python seems to have a bug with ints and booleans in the same map which evaluate to the same value
     # which the test data for this test has. For example: {1: 'value1', true: 'value2'}]).
@@ -79,7 +83,7 @@ def get_eval_error_message(test: simple_pb2.SimpleTest) -> str | None:
 
 
 # The test data from the cel-spec conformance tests
-cel_test_data = load_test_data("test/testdata/string_ext.textproto")
+cel_test_data = load_test_data(f"test/testdata/string_ext_{CEL_SPEC_VERSION}.textproto")
 # Our supplemental tests of functionality not in the cel conformance file, but defined in the spec.
 supplemental_test_data = load_test_data("test/testdata/string_ext_supplemental.textproto")
 

test/testdata/string_ext.textproto …st/testdata/string_ext_v0.25.1.textprototest/testdata/string_ext.textproto renamed to test/testdata/string_ext_v0.25.1.textproto test/testdata/string_ext.textproto renamed to test/testdata/string_ext_v0.25.1.textproto

@@ -92,7 +92,11 @@ section: {
 section: {
   name: "last_index_of"
   test: {
-    name: "empty"
+    name: "empty_string"
+    expr: "''.lastIndexOf('@@') == -1"
+  }
+  test: {
+    name: "empty_argument"
     expr: "'tacocat'.lastIndexOf('') == 7"
   }
   test: {
@@ -884,6 +888,76 @@ section: {
       string_value: '2.718280',
     }
   }
+test: {
+    name: "format_%f_insignificant_zeroes_removed"
+    expr: '"%.0f".format([123.000000])'
+    value: {
+      string_value: '123',
+    }
+  }
+  test: {
+    name: "format_%f_positive_round_to_whole_number"
+    expr: '"%.0f".format([3.5001])'
+    value: {
+      string_value: '4',
+    }
+  }
+  test: {
+    name: "format_%f_negative_truncate_to_whole_number"
+    expr: '"%.0f".format([3.4999])'
+    value: {
+      string_value: '3',
+    }
+  }
+  test: {
+    name: "format_%f_halfway_round_up_to_nearest_even"
+    expr: '"%.0f".format([1.5])'
+    value: {
+      string_value: '2',
+    }
+  }
+  test: {
+    name: "format_%f_halfway_truncate_to_nearest_even"
+    expr: '"%.0f".format([2.5])'
+    value: {
+      string_value: '2',
+    }
+  }
+  test: {
+    name: "format_%f_positive_round_up"
+    expr: '"%.3f".format([123.4999])'
+    value: {
+      string_value: '123.500',
+    }
+  }
+  test: {
+    name: "format_%f_positive_round_down"
+    expr: '"%.3f".format([123.4994])'
+    value: {
+      string_value: '123.499',
+    }
+  }
+  test: {
+    name: "format_%f_negative_round_up"
+    expr: '"%.3f".format([-123.4999])'
+    value: {
+      string_value: '-123.500',
+    }
+  }
+  test: {
+    name: "format_%f_negative_round_down"
+    expr: '"%.3f".format([-123.4994])'
+    value: {
+      string_value: '-123.499',
+    }
+  }
+  test: {
+    name: "format_%f_zero_padding"
+    expr: '"%.5f".format([-1.2])'
+    value: {
+      string_value: '-1.20000',
+    }
+  }
 }
 section: {
   name: "format_errors"