convert user admission to postgres stored function

Author: Mohit-Davar

migrations/20260409201624_admit_user_func.js

@@ -0,0 +1,27 @@
+exports.up = async function (knex) {
+  return knex.schema
+    .raw(
+      `CREATE OR REPLACE FUNCTION admit_user(user_pubkey BYTEA, tos_accepted TIMESTAMP WITHOUT TIME ZONE)
+RETURNS INTEGER
+LANGUAGE plpgsql
+AS $$
+BEGIN
+    PERFORM ASSERT_SERIALIZED();
+
+    INSERT INTO "users" ("pubkey", "is_admitted", "tos_accepted_at", "created_at", "updated_at")
+    VALUES (user_pubkey, true, tos_accepted, now_utc(), now_utc())
+    ON CONFLICT ("pubkey")
+    DO UPDATE SET
+      "is_admitted" = true,
+      "tos_accepted_at" = tos_accepted,
+      "updated_at" = now_utc();
+
+    RETURN 0;
+END;
+$$;`)
+}
+
+exports.down = function (knex) {
+  return knex.schema
+    .raw('DROP FUNCTION IF EXISTS admit_user(BYTEA, TIMESTAMP WITHOUT TIME ZONE);')
+}

src/@types/repositories.ts

@@ -43,4 +43,5 @@ export interface IUserRepository {
   findByPubkey(pubkey: Pubkey, client?: DatabaseClient): Promise<User | undefined>
   upsert(user: Partial<User>, client?: DatabaseClient): Promise<number>
   getBalanceByPubkey(pubkey: Pubkey, client?: DatabaseClient): Promise<bigint>
+  admitUser(pubkey: Pubkey, admittedAt: Date, client?: DatabaseClient): Promise<void>
 }

src/repositories/user-repository.ts

@@ -78,4 +78,26 @@ export class UserRepository implements IUserRepository {
 
     return BigInt(user.balance)
   }
+
+  public async admitUser(
+    pubkey: Pubkey,
+    admittedAt: Date,
+    client: DatabaseClient = this.dbClient,
+  ): Promise<void> {
+    debug('admit user: %s at %s', pubkey, admittedAt)
+
+    try {
+      await client.raw(
+        'select admit_user(?, ?)',
+        [
+          toBuffer(pubkey),
+          admittedAt.toISOString(),
+        ]
+      )
+    } catch (error) {
+      console.error('Unable to admit user. Reason:', error.message)
+
+      throw error
+    }
+  }
 }

src/services/payments-service.ts

@@ -184,14 +184,9 @@ export class PaymentsService implements IPaymentsService {
           && amountPaidMsat >= admissionFeeAmount
         ) {
           const date = new Date()
-          // TODO: Convert to stored func
-          await this.userRepository.upsert(
-            {
-              pubkey: invoice.pubkey,
-              isAdmitted: true,
-              tosAcceptedAt: date,
-              updatedAt: date,
-            },
+          await this.userRepository.admitUser(
+            invoice.pubkey,
+            date,
             transaction.transaction,
           )
         }