Enhancement sdm service binding lookup by tags for supporting User-Provided scenario

[Cachetian]

Hi team,

Our use case DMS service instance is created in isolated SubAccount and space, the method TokenHandler failed to lookup service binding sdm due to it's using service name (service plan name) only.

Code:

sdm/sdm/src/main/java/com/sap/cds/sdm/handler/TokenHandler.java

Line 74 in 50b4987

.filter(binding -> "sdm".equalsIgnoreCase(binding.getServiceName().orElse(null)))

AS-IS
.filter(binding -> "sdm".equalsIgnoreCase(binding.getServiceName().orElse(null)))

TO-BE
.filter(binding -> binding.getTags().contains("sdm"))

Error message: SDM binding not found

Could you please check?

[yashmeet29]

Hi @Cachetian,
What is the SDM service name which is bound to your application. Is it not "sdm"

Regards,
Yashmeet

[Cachetian]

Hi @yashmeet29

SDM service name cannot be "sdm" here, because the SDM service plan is not available in the same SubAccount and Space, in the most common use case, the SDM service is centrally managed in standalone SubAccount for all solutions. the workaround would be creating User-Provided service instance using the same tags as SDM service instance.

It would be very helpful, the "sdm" tags can be also used as filtering condition of Service Binding.

BR

[yashmeet29]

Hi @Cachetian, we are looking into this and will get back on this as soon as we have some updates.

Regards,
Yashmeet