Remove 'D' ?

[lpatiny]

nmrium/src/component/modal/PublicationStringModal.tsx

Lines 41 to 47 in 65c80a2

	// todo this 'D' is a hack and it should be in fact an empty string
	// by default the formatter always add the chemical shift
	// need to remove:
	// https://github.com/cheminfo/nmrium/blob/c2f67752c4ae831d9924a529878717170367dc1a/src/component/hooks/use_publication_strings.ts#L61-L64
	// and change the default formatting value for carbon in workspaceDefaultProperties.ts
	type ExportFormatType = 'IMJA' | 'IMJ' | 'D' | 'A';

Not sure why we can not use an empty string but seems not the right way to do.

[hamed-musallam]

@lpatiny
We use D visually, but the value I pass to the function is different, as you can see here. Also, we discussed this here #3640 (comment)

#3677

nmrium/src/component/hooks/use_publication_strings.ts

Lines 54 to 64 in 65c80a2

	const rangesToACSOptions: RangesToACSOptions = {
	nucleus,
	observedFrequency: originFrequency,
	...otherOptions,
	format: '',
	};
	if (format !== 'D') {
	rangesToACSOptions.format = format;
	rangesToACSOptions.couplingFormat = couplingFormat;
	}

[lpatiny]

Yes I saw this but why it is not simply an empty string rather than a string that we change after.

[hamed-musallam]

Do you mean in the function options, or do you mean in the drop-down menu?

[lpatiny]

The value in the drop down menu (which is hidden from the user). It is weird to set a value that somewhere else in the code your remove. So I do not why it is not always empty when we only want delta.

[hamed-musallam]

Sorry, Luc, I'm not sure what the issue is here. From my understanding, there are two cases:

Case 1: We pass D as a value, we display the delta.
Case 2: We pass an empty value, and we also only display the delta, and add a comment explaining that when the value is empty, it means we only display the delta

In both cases, the behavior seems the same. What is the value of passing an empty value?

From my point of view, we should pass D down to the function instead of having this condition. This should be handled internally in the rangeToACS function.