From b05dcca3d6b27088e0e938cdd8e621e66242c356 Mon Sep 17 00:00:00 2001
From: Flavio Wuensche <f.wuensche@gmail.com>
Date: Thu, 12 Mar 2026 10:44:20 +0100
Subject: [PATCH 1/6] chore: remove Dependabot configuration

GitHub will still create PRs for security vulnerabilities even without
this file, since Dependabot security updates are controlled separately
in the repository settings.
---
 .github/dependabot.yml | 26 --------------------------
 1 file changed, 26 deletions(-)
 delete mode 100644 .github/dependabot.yml

diff --git a/.github/dependabot.yml b/.github/dependabot.yml
deleted file mode 100644
index 825aa4cf..00000000
--- a/.github/dependabot.yml
+++ /dev/null
@@ -1,26 +0,0 @@
-# Please see the documentation for all configuration options:
-# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
-
-version: 2
-updates:
-  - package-ecosystem: 'bundler'
-    directory: '/'
-    versioning-strategy: 'lockfile-only'
-    schedule:
-      interval: 'weekly'
-      day: 'friday'
-      time: '05:00'
-    commit-message:
-      prefix: chore
-      include: 'scope'
-
-  - package-ecosystem: 'npm'
-    directory: '/'
-    versioning-strategy: 'increase'
-    schedule:
-      interval: 'weekly'
-      day: 'friday'
-      time: '05:00'
-    commit-message:
-      prefix: chore
-      include: 'scope'

From 9f8bafba082cf6c8824f6458da3aeb79631e0899 Mon Sep 17 00:00:00 2001
From: Flavio Wuensche <f.wuensche@gmail.com>
Date: Thu, 12 Mar 2026 11:04:23 +0100
Subject: [PATCH 2/6] fix: use find().click to avoid stale element error in
 sign_in helper

The `click_on 'Login'` call could fail with "Node with given id does
not belong to the document" when React re-renders the page between
Capybara finding and clicking the element. Using `find().click` lets
Capybara retry on stale element references.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 test/helpers/sign_in_helper.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/helpers/sign_in_helper.rb b/test/helpers/sign_in_helper.rb
index 2551f433..27e16e40 100644
--- a/test/helpers/sign_in_helper.rb
+++ b/test/helpers/sign_in_helper.rb
@@ -8,7 +8,7 @@ def sign_in(user = default_user, to: nil, controller_test: false)
       get '/auth/google_oauth2/callback'
     else
       visit root_path
-      click_on 'Login', match: :first
+      find('a', text: 'Login', match: :first).click
       assert_text "Signed in as #{user.name}"
       to ? visit(to) : refresh
     end

From a28112471faff812c0d0a5d2067ad18026a380d4 Mon Sep 17 00:00:00 2001
From: Flavio Wuensche <f.wuensche@gmail.com>
Date: Thu, 12 Mar 2026 13:05:05 +0100
Subject: [PATCH 3/6] fix: use :button selector for Login in sign_in helper

The Login element is a <button>, not an <a> tag. The previous fix
incorrectly used find('a', ...) which caused all system tests to fail
with Capybara::ElementNotFound.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 test/helpers/sign_in_helper.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/helpers/sign_in_helper.rb b/test/helpers/sign_in_helper.rb
index 27e16e40..d407d009 100644
--- a/test/helpers/sign_in_helper.rb
+++ b/test/helpers/sign_in_helper.rb
@@ -8,7 +8,7 @@ def sign_in(user = default_user, to: nil, controller_test: false)
       get '/auth/google_oauth2/callback'
     else
       visit root_path
-      find('a', text: 'Login', match: :first).click
+      find(:button, text: /Login/, match: :first).click
       assert_text "Signed in as #{user.name}"
       to ? visit(to) : refresh
     end

From e60dd30e28a843342b5357e31b03127aeb920784 Mon Sep 17 00:00:00 2001
From: Flavio Wuensche <f.wuensche@gmail.com>
Date: Thu, 12 Mar 2026 13:11:07 +0100
Subject: [PATCH 4/6] fix: retry assert_text after stale DOM error during
 sign-in

After clicking the Login button (form POST), the page navigates through
the OAuth callback and redirects. During this transition, assert_text
can hit a stale DOM node causing a Selenium UnknownError that Capybara
doesn't automatically retry. Rescue and retry once to handle the race.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 test/helpers/sign_in_helper.rb | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/test/helpers/sign_in_helper.rb b/test/helpers/sign_in_helper.rb
index d407d009..dd329915 100644
--- a/test/helpers/sign_in_helper.rb
+++ b/test/helpers/sign_in_helper.rb
@@ -9,7 +9,11 @@ def sign_in(user = default_user, to: nil, controller_test: false)
     else
       visit root_path
       find(:button, text: /Login/, match: :first).click
-      assert_text "Signed in as #{user.name}"
+      begin
+        assert_text "Signed in as #{user.name}"
+      rescue Selenium::WebDriver::Error::UnknownError
+        assert_text "Signed in as #{user.name}"
+      end
       to ? visit(to) : refresh
     end
   end

From a6e04096831633da448e336e7166335559bb2c15 Mon Sep 17 00:00:00 2001
From: Flavio Wuensche <f.wuensche@gmail.com>
Date: Fri, 13 Mar 2026 12:46:24 +0100
Subject: [PATCH 5/6] fix: disable PaintHolding to prevent stale DOM errors in
 system tests

Revert sign_in helper back to simple click_on/assert_text. Instead, fix
the root cause by adding disable-features=PaintHolding Chrome flag which
prevents Chrome from holding stale page frames during navigation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 test/application_system_test_case.rb | 2 +-
 test/helpers/sign_in_helper.rb       | 8 ++------
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/test/application_system_test_case.rb b/test/application_system_test_case.rb
index 3af62a87..e80aca9a 100644
--- a/test/application_system_test_case.rb
+++ b/test/application_system_test_case.rb
@@ -8,7 +8,7 @@ class ApplicationSystemTestCase < ActionDispatch::SystemTestCase
 
   Capybara.server = :puma, { Silent: true } # removes noisy logs when launching tests
 
-  common_options = %w[window-size=1400,1000 disable-search-engine-choice-screen]
+  common_options = %w[window-size=1400,1000 disable-search-engine-choice-screen disable-features=PaintHolding]
 
   Capybara.register_driver :headless_chrome do |app|
     options = Selenium::WebDriver::Chrome::Options.new(args: %w[headless].concat(common_options))
diff --git a/test/helpers/sign_in_helper.rb b/test/helpers/sign_in_helper.rb
index dd329915..2551f433 100644
--- a/test/helpers/sign_in_helper.rb
+++ b/test/helpers/sign_in_helper.rb
@@ -8,12 +8,8 @@ def sign_in(user = default_user, to: nil, controller_test: false)
       get '/auth/google_oauth2/callback'
     else
       visit root_path
-      find(:button, text: /Login/, match: :first).click
-      begin
-        assert_text "Signed in as #{user.name}"
-      rescue Selenium::WebDriver::Error::UnknownError
-        assert_text "Signed in as #{user.name}"
-      end
+      click_on 'Login', match: :first
+      assert_text "Signed in as #{user.name}"
       to ? visit(to) : refresh
     end
   end

From 3b50096ea911e9a5fb21d693b83f3e7dac113a80 Mon Sep 17 00:00:00 2001
From: Flavio Wuensche <f.wuensche@gmail.com>
Date: Fri, 13 Mar 2026 12:51:21 +0100
Subject: [PATCH 6/6] chore: add comment explaining PaintHolding Chrome flag

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 test/application_system_test_case.rb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/test/application_system_test_case.rb b/test/application_system_test_case.rb
index e80aca9a..f4ad356c 100644
--- a/test/application_system_test_case.rb
+++ b/test/application_system_test_case.rb
@@ -8,6 +8,9 @@ class ApplicationSystemTestCase < ActionDispatch::SystemTestCase
 
   Capybara.server = :puma, { Silent: true } # removes noisy logs when launching tests
 
+  # PaintHolding makes Chrome keep displaying the old page during navigation, which causes
+  # Selenium to reference stale DOM nodes and fail with "Node with given id does not belong
+  # to the document". Disabling it lets the page clear immediately on navigation.
   common_options = %w[window-size=1400,1000 disable-search-engine-choice-screen disable-features=PaintHolding]
 
   Capybara.register_driver :headless_chrome do |app|