enhance readability

Author: dominikzogg

src/Schema/BoolSchema.php

@@ -44,16 +44,16 @@ public function toString(): StringSchema
 
     protected function innerParse(mixed $input): mixed
     {
-        if (!\is_bool($input)) {
-            throw new ErrorsException(
-                new Error(
-                    self::ERROR_TYPE_CODE,
-                    self::ERROR_TYPE_TEMPLATE,
-                    ['given' => $this->getDataType($input)]
-                )
-            );
+        if (\is_bool($input)) {
+            return $input;
         }
 
-        return $input;
+        throw new ErrorsException(
+            new Error(
+                self::ERROR_TYPE_CODE,
+                self::ERROR_TYPE_TEMPLATE,
+                ['given' => $this->getDataType($input)]
+            )
+        );
     }
 }

src/Schema/DateTimeSchema.php

@@ -21,34 +21,34 @@ final class DateTimeSchema extends AbstractSchemaInnerParse implements SchemaInt
     public function from(\DateTimeImmutable $from): static
     {
         return $this->postParse(static function (\DateTimeImmutable $datetime) use ($from) {
-            if ($datetime < $from) {
-                throw new ErrorsException(
-                    new Error(
-                        self::ERROR_FROM_CODE,
-                        self::ERROR_FROM_TEMPLATE,
-                        ['from' => $from->format('c'), 'given' => $datetime->format('c')]
-                    )
-                );
+            if ($datetime >= $from) {
+                return $datetime;
             }
 
-            return $datetime;
+            throw new ErrorsException(
+                new Error(
+                    self::ERROR_FROM_CODE,
+                    self::ERROR_FROM_TEMPLATE,
+                    ['from' => $from->format('c'), 'given' => $datetime->format('c')]
+                )
+            );
         });
     }
 
     public function to(\DateTimeImmutable $to): static
     {
         return $this->postParse(static function (\DateTimeImmutable $datetime) use ($to) {
-            if ($datetime > $to) {
-                throw new ErrorsException(
-                    new Error(
-                        self::ERROR_TO_CODE,
-                        self::ERROR_TO_TEMPLATE,
-                        ['to' => $to->format('c'), 'given' => $datetime->format('c')]
-                    )
-                );
+            if ($datetime <= $to) {
+                return $datetime;
             }
 
-            return $datetime;
+            throw new ErrorsException(
+                new Error(
+                    self::ERROR_TO_CODE,
+                    self::ERROR_TO_TEMPLATE,
+                    ['to' => $to->format('c'), 'given' => $datetime->format('c')]
+                )
+            );
         });
     }
 
@@ -74,16 +74,16 @@ public function toString(): StringSchema
 
     protected function innerParse(mixed $input): mixed
     {
-        if (!$input instanceof \DateTimeInterface) {
-            throw new ErrorsException(
-                new Error(
-                    self::ERROR_TYPE_CODE,
-                    self::ERROR_TYPE_TEMPLATE,
-                    ['given' => $this->getDataType($input)]
-                )
-            );
+        if ($input instanceof \DateTimeInterface) {
+            return $input;
         }
 
-        return $input;
+        throw new ErrorsException(
+            new Error(
+                self::ERROR_TYPE_CODE,
+                self::ERROR_TYPE_TEMPLATE,
+                ['given' => $this->getDataType($input)]
+            )
+        );
     }
 }

tests/Unit/Schema/DateTimeSchemaTest.php

@@ -25,6 +25,8 @@ public function testImmutability(): void
         self::assertNotSame($schema, $schema->preParse(static fn (mixed $input) => $input));
         self::assertNotSame($schema, $schema->postParse(static fn (\DateTimeInterface $output) => $output));
         self::assertNotSame($schema, $schema->catch(static fn (\DateTimeInterface $output, ErrorsException $e) => $output));
+        self::assertNotSame($schema, $schema->from(new \DateTimeImmutable('2024-01-20T09:15:00+00:00')));
+        self::assertNotSame($schema, $schema->to(new \DateTimeImmutable('2024-01-20T09:15:00+00:00')));
     }
 
     public function testParseSuccess(): void