You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: packages/plugin-lighthouse/CONTRIBUTING.md
+5-5Lines changed: 5 additions & 5 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -15,7 +15,7 @@ To test lighthouse properly we work with a predefined testing setup.
15
15
16
16
On some OS there could be a problem finding the path to Chrome.
17
17
18
-
We try to detect it automatically in the [`chrome-path.mock.ts` script](../../testing/test-setup/src/lib/chrome-path.mock.ts).
18
+
We try to detect it automatically in the [`chrome-path.setup-file.ts` script](../../testing/test-setup/src/lib/chrome-path.setup-file.ts).
19
19
There we use `getChromePath` and have `chromium` installed as NPM package, so detecting the path should not cause any problem.
20
20
21
21
However, if no chrome path is detected automatically the error looks like this:
@@ -46,7 +46,7 @@ In the CI you can set a static path if needed over the env variable like this:
46
46
# ...
47
47
```
48
48
49
-
We consider this path in our `beforeAll` hook in a [`chrome-path.mock.ts` script](../../testing/test-setup/src/lib/chrome-path.mock.ts).
49
+
We consider this path in our `beforeAll` hook in a [`chrome-path.setup-file.ts` script](../../testing/test-setup/src/lib/chrome-path.setup-file.ts).
50
50
51
51
### Testing chrome flags
52
52
@@ -66,15 +66,15 @@ For a full list of available flags check out [this document](https://peter.sh/ex
66
66
67
67
### Chrome User Data
68
68
69
-
To bootstrap Chrome with a predefined for setting we have to provide a couple of config files that we located under `<project-root>/mock/chromium-user-data`.
69
+
To bootstrap Chrome with a predefined for setting we have to provide a couple of config files that we located under `<project-root>/mocks/chromium-user-data`.
70
70
When executing Lighthouse we provide the path to this folder over the `Flag` object.
71
71
72
72
To generate initialise or edit the file structure under `chromium-user-data` do the following steps:
73
73
74
-
1. Spin up Chrome by running `npx chrome-debug --user-data-dir=./packages/plugin-lighthouse/mock/chromium-user-data`
74
+
1. Spin up Chrome by running `npx chrome-debug --user-data-dir=./packages/plugin-lighthouse/mocks/chromium-user-data`
0 commit comments