[compiler] fix source location for return statements (facebook#35660)

Fixes missing source locations for ReturnStatement nodes in generated
ast. Simple change using existing pattern, only required changes to the
codegen step, no other pipeline changes.

**Most file changes are new lines in generated code.** [First
commit](facebook@d15e90e)
has the relevant changes, second commit has the noisy snap updates.

I added an exception to the validator to not report an error when a
return statement will be optimized to an implicit return by codegen, as
there's no separate return statement to instrument anyways in the final
ast. An edge case when it comes to preserving source locations for
instrumentation that is likely not as common for most babel transforms
since they are not doing optimizations.

Author: nathanmarks

compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/CodegenReactiveFunction.ts

@@ -1160,9 +1160,9 @@ function codegenTerminal(
       const value = codegenPlaceToExpression(cx, terminal.value);
       if (value.type === 'Identifier' && value.name === 'undefined') {
         // Use implicit undefined
-        return t.returnStatement();
+        return createReturnStatement(terminal.loc);
       }
-      return t.returnStatement(value);
+      return createReturnStatement(terminal.loc, value);
     }
     case 'switch': {
       return createSwitchStatement(
@@ -1545,6 +1545,7 @@ const createThrowStatement = withLoc(t.throwStatement);
 const createTryStatement = withLoc(t.tryStatement);
 const createBreakStatement = withLoc(t.breakStatement);
 const createContinueStatement = withLoc(t.continueStatement);
+const createReturnStatement = withLoc(t.returnStatement);
 
 function createVariableDeclarator(
   id: t.LVal,

compiler/packages/babel-plugin-react-compiler/src/Validation/ValidateSourceLocations.ts

@@ -149,6 +149,23 @@ export function validateSourceLocations(
         return;
       }
 
+      /*
+       * Skip return statements inside arrow functions that will be simplified to expression body.
+       * The compiler transforms `() => { return expr }` to `() => expr` in CodegenReactiveFunction
+       */
+      if (t.isReturnStatement(node) && node.argument != null) {
+        const parentBody = path.parentPath;
+        const parentFunc = parentBody?.parentPath;
+        if (
+          parentBody?.isBlockStatement() &&
+          parentFunc?.isArrowFunctionExpression() &&
+          parentBody.node.body.length === 1 &&
+          parentBody.node.directives.length === 0
+        ) {
+          return;
+        }
+      }
+
       // Collect the location if it exists
       if (node.loc) {
         const key = locationKey(node.loc);