Skip to content

Commit dcb8797

Browse files
authored
fix(ci): use valid action versions in release.yaml (#153)
- actions/checkout@v6 doesn't exist, use pinned v4 SHA - actions/setup-go@v6 doesn't exist, use pinned v5 SHA - Update go-version from 1.22 to 1.24 for consistency with ci.yaml - Fix test goroutine leak: close yamux session when context done
1 parent ad14115 commit dcb8797

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

.github/workflows/release.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@ jobs:
2020
runs-on: ubuntu-latest
2121
steps:
2222
- name: Checkout
23-
uses: actions/checkout@v6
23+
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
2424

2525
- name: Setup Go
26-
uses: actions/setup-go@v6
26+
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5
2727
with:
28-
go-version: "~1.22"
28+
go-version: "~1.24"
2929

3030
- name: Get Version
3131
run: echo "version=$(./scripts/version.sh)" >> $GITHUB_OUTPUT

logger_test.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1228,7 +1228,13 @@ func newFakeAgentAPI(t *testing.T) *fakeAgentAPI {
12281228
Message: "Failed to accept websocket.",
12291229
Detail: err.Error(),
12301230
})
1231+
return
12311232
}
1233+
// Ensure session is closed when context is done to unblock Serve
1234+
go func() {
1235+
<-ctx.Done()
1236+
_ = session.Close()
1237+
}()
12321238

12331239
err = dserver.Serve(ctx, session)
12341240
logger.Info(ctx, "drpc serveone", slog.Error(err))

0 commit comments

Comments
 (0)