Skip to content

Commit 89a25f0

Browse files
authored
Merge pull request #305 from coderefinery/radovan/code-review
small improvements in episode where we practice code review
2 parents 682563d + 50ef256 commit 89a25f0

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

content/code-review.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Practicing code review
22

3-
In this episode we will practice the code review process. We will learn how to
3+
In this episode we will practice the **code review process**. We will learn how to
44
ask for changes in a pull request, how to suggest a change in a pull request,
55
and how to modify a pull request.
66

@@ -20,7 +20,7 @@ previous episode.
2020
**Technical requirements**:
2121
- If you create the commits locally: [Being able to authenticate to GitHub](https://coderefinery.github.io/installation/ssh/)
2222

23-
**What is familiar** from the previous workshop days:
23+
**What is familiar** from previous episodes:
2424
- Creating a branch ([previous lesson](https://coderefinery.github.io/git-intro/commits/))
2525
- Committing a change on the new branch ([previous lesson](https://coderefinery.github.io/git-intro/commits/))
2626
- Opening and merging pull requests ([previous lesson](https://coderefinery.github.io/git-intro/merging/))
@@ -83,7 +83,7 @@ goal is not gate-keeping but **collaborative learning**.
8383
If you see a very small problem that is easy to fix, you can suggest a change
8484
as a reviewer.
8585

86-
Instead of asking the submitter to tiny problem, you can suggest a change by
86+
Instead of asking the submitter to fix the tiny problem, you can suggest a change by
8787
clicking on the plus sign next to the line number in the "Files changed" tab:
8888
:::{figure} img/code-review/leave-comment.png
8989
:width: 100%
@@ -110,7 +110,7 @@ The result is this and the submitter can accept the change with a single click:
110110
::::
111111

112112
After accepting with "Commit suggestion", the improvement gets added to the
113-
pull request.
113+
pull request as a new commit.
114114

115115

116116
### How to modify a pull request to address the review comments

0 commit comments

Comments
 (0)