The Crop module isn't working properly when I use it in the Quick Access Toolbar.

[lepolau]

Is there an existing issue for this?

• I checked and did not find my issue in the already reported ones

Describe the bug

The Crop module isn't working properly when I use it in the Quick Access Toolbar. I can enable or disable the module without any issues, but I can't access the frame's selection outline; the guidelines appear, but the borders seem to be outside the image.
Selecting the aspect ratio doesn't change anything, but it seems to be working.

Steps to reproduce

1 Enable the cropping tool's features in the Quick Access Toolbar
2 Use the tool to crop an image
3 Try selecting the cropping frame
4 see the error, the borders seem to be outside the image.

Expected behavior

No response

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

darktable.org / GitHub release

darktable version

7abae9d

What OS are you using?

Linux

What is the version of your OS?

arch linux

Describe your system

arch linux gnome 50 wayland dell vostro 5515 amd ryzen 7 + amd gpu without opencl

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

I can reproduce it with older darktable master since 5.5; perhaps later, but I don't test it.

[ralfbrown]

There's a technical limitation that a module's on-image controls are only displayed when the module is open and focused. When changing settings from the QAP, that isn't the case.... This limitation is why the crop module is not on the QAP by default.

I'm afraid it's working as designed, but the design could use some improvement now that we have the QAP.

For 5.4+, you should use the 'c' shortcut key to enable the crop box. This will take you out of the QAP, though, since it opens and focuses the crop module so that the crop box is actually shown.

[da-phil]

There's a technical limitation that a module's on-image controls are only displayed when the module is open and focused. When changing settings from the QAP, that isn't the case.... This limitation is why the crop module is not on the QAP by default.

I'm afraid it's working as designed, but the design could use some improvement now that we have the QAP.

For 5.4+, you should use the 'c' shortcut key to enable the crop box. This will take you out of the QAP, though, since it opens and focuses the crop module so that the crop box is actually shown.

I didn't know this behavior until I gave it a shot too, but I have to say that the current functionality of the crop module in QAP is really not helpful, I would rather have the entire module instead of those - for me - useless aspect ratio and crop sliders. I was not able to find any useful workflow to achieve one of my typical use-cases. Maybe remove the crop module entirely from the QAP selection or add it as a whole with the margin box removed and the actual ability to crop?