From 1f573650f86537a6b565321f0331c6239a4f7f08 Mon Sep 17 00:00:00 2001
From: Daniel Duan <daniel@duan.ca>
Date: Thu, 5 Feb 2026 23:27:58 -0800
Subject: [PATCH] Flatten key lookup pointer loops

Reduce overhead in Parser key lookup by removing nested withUnsafeBufferPointer closures in matchKeyValue/matchKeyArray/matchKeyTable.

Each matcher now opens one buffer pointer for backing storage and scans borrowed index lists with simple index-based loops and pointer advances.

Behavior is unchanged; this targets instruction count in repeated table/key lookup paths.
---
 Sources/TOMLDecoder/Parsing/Parser.swift | 63 +++++++++---------------
 1 file changed, 24 insertions(+), 39 deletions(-)

diff --git a/Sources/TOMLDecoder/Parsing/Parser.swift b/Sources/TOMLDecoder/Parsing/Parser.swift
index 55032fb..e261691 100644
--- a/Sources/TOMLDecoder/Parsing/Parser.swift
+++ b/Sources/TOMLDecoder/Parsing/Parser.swift
@@ -1905,21 +1905,16 @@ extension Parser {
             guard let keyValueBase = keyValueBuffer.baseAddress else {
                 return nil
             }
-            return indices.withUnsafeBufferPointer { indexBuffer in
-                guard let indexBase = indexBuffer.baseAddress else {
-                    return nil
+            var i = 0
+            while i < indices.count {
+                let keyValueIndex = indices[i]
+                let keyValuePair = keyValueBase.advanced(by: keyValueIndex).pointee
+                if keyValuePair.keyHash == keyHash, keyValuePair.key == key {
+                    return keyValueIndex
                 }
-                var i = 0
-                while i < indexBuffer.count {
-                    let keyValueIndex = indexBase[i]
-                    let keyValuePair = keyValueBase[keyValueIndex]
-                    if keyValuePair.keyHash == keyHash, keyValuePair.key == key {
-                        return keyValueIndex
-                    }
-                    i += 1
-                }
-                return nil
+                i += 1
             }
+            return nil
         }
     }
 
@@ -1932,21 +1927,16 @@ extension Parser {
             guard let keyArrayBase = keyArrayBuffer.baseAddress else {
                 return nil
             }
-            return indices.withUnsafeBufferPointer { indexBuffer in
-                guard let indexBase = indexBuffer.baseAddress else {
-                    return nil
-                }
-                var i = 0
-                while i < indexBuffer.count {
-                    let keyArrayIndex = indexBase[i]
-                    let keyArrayPair = keyArrayBase[keyArrayIndex]
-                    if keyArrayPair.keyHash == keyHash, keyArrayPair.key == key {
-                        return keyArrayIndex
-                    }
-                    i += 1
+            var i = 0
+            while i < indices.count {
+                let keyArrayIndex = indices[i]
+                let keyArrayPair = keyArrayBase.advanced(by: keyArrayIndex).pointee
+                if keyArrayPair.keyHash == keyHash, keyArrayPair.key == key {
+                    return keyArrayIndex
                 }
-                return nil
+                i += 1
             }
+            return nil
         }
     }
 
@@ -1959,21 +1949,16 @@ extension Parser {
             guard let keyTableBase = keyTableBuffer.baseAddress else {
                 return nil
             }
-            return indices.withUnsafeBufferPointer { indexBuffer in
-                guard let indexBase = indexBuffer.baseAddress else {
-                    return nil
-                }
-                var i = 0
-                while i < indexBuffer.count {
-                    let keyTableIndex = indexBase[i]
-                    let keyTablePair = keyTableBase[keyTableIndex]
-                    if keyTablePair.keyHash == keyHash, keyTablePair.key == key {
-                        return keyTableIndex
-                    }
-                    i += 1
+            var i = 0
+            while i < indices.count {
+                let keyTableIndex = indices[i]
+                let keyTablePair = keyTableBase.advanced(by: keyTableIndex).pointee
+                if keyTablePair.keyHash == keyHash, keyTablePair.key == key {
+                    return keyTableIndex
                 }
-                return nil
+                i += 1
             }
+            return nil
         }
     }