[IMP] vcp_*: get 'draft' state of pull requests. add a new 'status' field on vcp.request, that is based on 'is_draft', 'is_merged' and 'state' field to display the correct ribbon on form view / badge on list view

Author: legalsylvain

vcp_github/models/vcp_repository.py

@@ -85,6 +85,7 @@ def _parse_github_pr(self, pr, client):
                 "name": pr.title,
                 "is_merged": any(label["name"] == "merged 🎉" for label in pr.labels)
                 or pr.is_merged(),
+                "is_draft": pr.draft,
                 "created_at": self.platform_id._parse_github_date(
                     origin_data["created_at"]
                 ),

vcp_management/models/vcp_request.py

@@ -3,6 +3,13 @@
 
 from odoo import api, fields, models
 
+_STATUS_SELECTION = [
+    ("draft", "Draft"),
+    ("open", "Open"),
+    ("merged", "Merged"),
+    ("closed", "Closed"),
+]
+
 
 class VcpRequest(models.Model):
     """
@@ -57,7 +64,11 @@ class VcpRequest(models.Model):
     comment_count = fields.Integer(compute="_compute_comment_count", store=True)
     url = fields.Char(readonly=True)
     state = fields.Char(readonly=True)
+    status = fields.Selection(
+        selection=_STATUS_SELECTION, compute="_compute_status", store=True
+    )
     is_merged = fields.Boolean(readonly=True)
+    is_draft = fields.Boolean(readonly=True)
     created_at = fields.Datetime(readonly=True)
     updated_at = fields.Datetime(readonly=True)
     closed_at = fields.Datetime(readonly=True)
@@ -86,3 +97,15 @@ def _compute_review_count(self):
     def _compute_comment_count(self):
         for record in self:
             record.comment_count = len(record.comment_ids)
+
+    @api.depends("is_draft", "is_merged", "state")
+    def _compute_status(self):
+        for record in self:
+            if record.is_merged:
+                record.status = "merged"
+            elif record.closed_at:
+                record.status = "closed"
+            elif record.is_draft:
+                record.status = "draft"
+            else:
+                record.status = "open"

vcp_management/views/vcp_request.xml

@@ -48,18 +48,31 @@
                             />
                         </button>
                     </div>
+                    <widget
+                        name="web_ribbon"
+                        title="Draft"
+                        bg_color="bg-info"
+                        invisible="status != 'draft'"
+                    />
+                    <widget
+                        name="web_ribbon"
+                        title="Open"
+                        bg_color="bg-primary"
+                        invisible="status != 'open'"
+                    />
                     <widget
                         name="web_ribbon"
                         title="Merged"
                         bg_color="bg-success"
-                        invisible="not is_merged"
+                        invisible="status != 'merged'"
                     />
                     <widget
                         name="web_ribbon"
                         title="Closed"
                         bg_color="bg-danger"
-                        invisible="is_merged or not closed_at"
+                        invisible="status != 'closed'"
                     />
+                    <field name="is_draft" invisible="1" />
                     <field name="is_merged" invisible="1" />
                     <field name="closed_at" invisible="1" />
                     <group>
@@ -100,9 +113,17 @@
                 <field name="branch_id" />
                 <field name="number" />
                 <field name="name" />
-                <field name="url" widget="url" />
+                <field name="url" widget="url" optional="hide" />
                 <field name="comment_count" optional="hide" />
                 <field name="review_count" optional="hide" />
+                <field
+                    name="status"
+                    decoration-info="status == 'draft'"
+                    decoration-primary="status == 'open'"
+                    decoration-success="status == 'merged'"
+                    decoration-danger="status == 'closed'"
+                    widget="badge"
+                />
             </list>
         </field>
     </record>