From 821a681e5e6b2a66481391fe27d38166b10122ab Mon Sep 17 00:00:00 2001 From: Gabor Torok Date: Tue, 10 Feb 2026 17:05:25 -0800 Subject: [PATCH 1/2] Facility api fix in case the adapter returns null --- app/routers/facility/facility.py | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/app/routers/facility/facility.py b/app/routers/facility/facility.py index aa9bd2c..cd29429 100644 --- a/app/routers/facility/facility.py +++ b/app/routers/facility/facility.py @@ -1,4 +1,4 @@ -from fastapi import Depends, Query, Request +from fastapi import Depends, Query, Request, HTTPException from ...types.http import forbidExtraQueryParams from ...types.scalars import StrictDateTime @@ -10,13 +10,17 @@ @router.get("", responses=DEFAULT_RESPONSES, operation_id="getFacility", response_model_exclude_none=True,) +@router.get("/", responses=DEFAULT_RESPONSES, operation_id="getFacilityWithSlash", response_model_exclude_none=True,) async def get_facility( request: Request, modified_since: StrictDateTime = Query(default=None), _forbid=Depends(forbidExtraQueryParams("modified_since")), ) -> models.Facility: """Get facility information""" - return await router.adapter.get_facility(modified_since=modified_since) + facility = await router.adapter.get_facility(modified_since=modified_since) + if not facility: + raise HTTPException(status_code=404, detail="Facility not found") + return facility @router.get("/sites", responses=DEFAULT_RESPONSES, operation_id="getSites", response_model_exclude_none=True,) @@ -41,4 +45,7 @@ async def get_site( _forbid=Depends(forbidExtraQueryParams("modified_since")), ) -> models.Site: """Get site by ID""" - return await router.adapter.get_site(site_id=site_id, modified_since=modified_since) + site = await router.adapter.get_site(site_id=site_id, modified_since=modified_since) + if not site: + raise HTTPException(status_code=404, detail="Site not found") + return site From 195387999aaf7968fca64bf454d687f77ef4e1bf Mon Sep 17 00:00:00 2001 From: Gabor Torok Date: Tue, 10 Feb 2026 17:09:10 -0800 Subject: [PATCH 2/2] hide facility/ from swagger --- app/routers/facility/facility.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/routers/facility/facility.py b/app/routers/facility/facility.py index cd29429..1ab5b5c 100644 --- a/app/routers/facility/facility.py +++ b/app/routers/facility/facility.py @@ -10,7 +10,7 @@ @router.get("", responses=DEFAULT_RESPONSES, operation_id="getFacility", response_model_exclude_none=True,) -@router.get("/", responses=DEFAULT_RESPONSES, operation_id="getFacilityWithSlash", response_model_exclude_none=True,) +@router.get("/", responses=DEFAULT_RESPONSES, operation_id="getFacilityWithSlash", response_model_exclude_none=True, include_in_schema=False,) async def get_facility( request: Request, modified_since: StrictDateTime = Query(default=None),