-
Notifications
You must be signed in to change notification settings - Fork 566
[CoreCLR] Enable R2R when publishing with custom Configuration value #11069
Copy link
Copy link
Labels
Area: CoreCLRIssues that only occur when using CoreCLR.Issues that only occur when using CoreCLR.
Milestone
Description
A customer ran into a problem where R2R did not run after switching to CoreCLR. The problem was that they used publish with customized configuration value. The customized Configuration allows them to easily switching between different app variants in visiual studio.
We should consider checking for '$(Configuration)' == 'Release' or '$(_IsPublishing)' == 'true':
Lines 14 to 21 in fa20c91
| <!-- Properties for $(OutputType)=Exe (Android Applications) --> | |
| <PropertyGroup Condition=" '$(AndroidApplication)' == 'true' "> | |
| <!-- Default to R2R Composite for CoreCLR Release mode --> | |
| <PublishReadyToRun Condition=" '$(PublishReadyToRun)' == '' and '$(Configuration)' == 'Release' ">true</PublishReadyToRun> | |
| <PublishReadyToRunComposite Condition=" '$(PublishReadyToRunComposite)' == '' and '$(PublishReadyToRun)' == 'true' ">true</PublishReadyToRunComposite> | |
| <_IsPublishing Condition=" '$(_IsPublishing)' == '' and '$(PublishReadyToRun)' == 'true' ">true</_IsPublishing> | |
| <AllowReadyToRunWithoutRuntimeIdentifier Condition=" '$(PublishReadyToRun)' == 'true' and '$(RuntimeIdentifiers)' != '' ">true</AllowReadyToRunWithoutRuntimeIdentifier> | |
| </PropertyGroup> |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area: CoreCLRIssues that only occur when using CoreCLR.Issues that only occur when using CoreCLR.