Differences in assembly versions between source-build and Microsoft build

[omajid]

Describe the Bug

I am comparing versions (Assembly Version, File Version, Product Version) between a source-built .NET 11 Preview 1 and a Microsoft-build of the same. There are a number of differences. It might be possible to fix some. Here's a non-exhaustive list. SB = Source BUild, MB = Microsoft build.

• sdk/11.0.100-preview.1.26104.118/Containers/tasks/net11.0/Valleysoft.DockerCredsProvider.dll:
  • SB Product Version: 2.2.4+87bc0b04e21d786669142109a5128c95618b75ed
  • MB Product Version: 2.2.4+6e1ecd0a80755f9f0e88dc23b98b52f51a77c65e
• sdk/11.0.100-preview.1.26104.118/cs/NuGet.Build.Tasks.Pack.resources.dll:
  • SB ProductVersionNumber: 7.4.0.0
  • MB ProductVersionNumber: 0.0.0.0
  • SB ProductVersion: 7.4.0-rc.10518+87bc0b04e21d786669142109a5128c95618b75ed
  • MB ProductVersion: 7.4.0-rc.10518+87bc0b04e21d786669142109a5128c95618b75ed.87bc0b04e21d786669142109a5128c95618b75ed
• sdk/11.0.100-preview.1.26104.118/cs/NuGet.Common.resources.dll:
  • SB ProductVersionNumber: 7.4.0.0
  • MB ProductVersionNumber: 0.0.0.0
  • SB ProductVersion: 7.4.0-rc.10518+87bc0b04e21d786669142109a5128c95618b75ed
  • MB ProductVersion: 7.4.0-rc.10518+87bc0b04e21d786669142109a5128c95618b75ed.87bc0b04e21d786669142109a5128c95618b75ed
• sdk/11.0.100-preview.1.26104.118/cs/NuGet.Configuration.resources.dll:
  • SB ProductVersionNumber: 7.4.0.0
  • MB ProductVersionNumber: 0.0.0.0
  • SB ProductVersion: 7.4.0-rc.10518+87bc0b04e21d786669142109a5128c95618b75ed
  • MB ProductVersion: 7.4.0-rc.10518+87bc0b04e21d786669142109a5128c95618b75ed.87bc0b04e21d786669142109a5128c95618b75ed
• sdk/11.0.100-preview.1.26104.118/Microsoft.ApplicationInsights.dll:
  • FileVersionNumber:
    • SB: 2.23.0.747
    • MB: 2.23.0.29
  • FileVersion:
    • SB: 2.23.0.00747
    • MB: 2.23.0.00029
  • ProductVersion:
    • SB: 2.23.0+87bc0b04e21d786669142109a5128c95618b75ed
    • MB: 2.23.0+2faa7e8b157a431daa2e71785d68abd5fa817b53
  • AssemblyVersion:
    • SB: 2.23.0.747
    • MB: 2.23.0.29
• sdk/11.0.100-preview.1.26104.118/Microsoft.VisualStudio.SolutionPersistence.dll:
  • FileVersionNumber:
    • SB: 1.0.52.0
    • MB: 1.0.52.6595
  • ProductVersionNumber:
    • SB: 1.0.0.0
    • MB: 1.0.52.0
  • FileVersion:
    • SB: 1.0.52
    • MB:1.0.52.6595
  • ProductVersion:
    • SB: 1.0.0+87bc0b04e21d786669142109a5128c95618b75ed
    • MB: 1.0.52+19c3ca7dc9.RR
• sdk/11.0.100-preview.1.26104.118/Sdks/Microsoft.NET.Sdk.Razor/tools/Microsoft.Css.Parser.dll:
  • ProductVersion:
    • SB: 1.0.0-20230414.1+87bc0b04e21d786669142109a5128c95618b75ed
    • MB: 1.0.0-20230414.1

Steps to Reproduce

1. Build source build 11 Preview 1
2. Get Microsoft's 11 Preview 1 SDK
3. Compare assemblies. I used exiftool on Fedora 43.

Other Information

[omajid]

I am not sure why this doesn't match with https://github.com/dotnet/dotnet/blob/main/test/Microsoft.DotNet.SourceBuild.Tests/assets/SdkContentTests/SdkAssemblyVersionDiffExclusions.txt

[mthalman]

Latest daily builds for main branch don't show any diffs for the NuGet assemblies anymore, so that's good.

The digest differences are caused by sourcelink which uses SourceRevisionId property that comes from the repo's commit hash. For the Microsoft build, it's consuming NuGet packages produced by the target repository (e.g. Microsoft.VisualStudio.SolutionPersistence is produced by the https://github.com/microsoft/vs-solutionpersistence repo). So the repo commit comes from that repo. But for source-build, it's building these external repos directly from the VMR and so SourceRevisionId is based on the VMR's commit hash which is going to be different. @omajid - Do you see this particular version difference as something that needs to be solved?

[akoeplinger]

We should be able to override the SourceRevisionId in source-build-reference-packages for the individual projects to the correct commit

[akoeplinger]

That said, I think at least for Microsoft.VisualStudio.SolutionPersistence.dll we're referencing a different version in SB vs MB.

v1.0.52 used in the MB is microsoft/vs-solutionpersistence@19c3ca7 but in source-build-reference-packages the submodule is referencing v1.0.28 microsoft/vs-solutionpersistence@0b6f82a